Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: remoting/webapp/crd/js/session_connector_impl.js

Issue 1082383002: [Webapp Refactor] Remove remoting.clientSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix browser tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/me2me_activity.js ('k') | remoting/webapp/crd/js/smart_reconnector.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/session_connector_impl.js
diff --git a/remoting/webapp/crd/js/session_connector_impl.js b/remoting/webapp/crd/js/session_connector_impl.js
index 6c197890d4805252e0c285de564e3320ac2412c3..438a1f05b0ec4ba428288a3b3bbf533ada5df624 100644
--- a/remoting/webapp/crd/js/session_connector_impl.js
+++ b/remoting/webapp/crd/js/session_connector_impl.js
@@ -13,13 +13,6 @@
var remoting = remoting || {};
/**
- * @type {remoting.ClientSession} The client session object, set once the
- * connector has invoked its onOk callback.
- * TODO(garykac): Have this owned by someone instead of being global.
- */
-remoting.clientSession;
-
-/**
* @param {HTMLElement} clientContainer Container element for the client view.
* @param {Array<string>} requiredCapabilities Connector capabilities
* required by this application.
@@ -75,7 +68,6 @@ remoting.SessionConnectorImpl.prototype.closeSession_ = function() {
base.dispose(this.clientSession_);
/** @private {remoting.ClientSession} */
this.clientSession_ = null;
- remoting.clientSession = null;
base.dispose(this.plugin_);
/** @private {remoting.ClientPlugin} */
@@ -209,7 +201,6 @@ remoting.SessionConnectorImpl.prototype.onPluginInitialized_ = function(
this.clientSession_ = new remoting.ClientSession(
this.plugin_, this.host_, this.signalStrategy_);
- remoting.clientSession = this.clientSession_;
this.clientSession_.logHostOfflineErrors(this.logHostOfflineErrors_);
this.eventHook_ = new base.EventHook(
« no previous file with comments | « remoting/webapp/crd/js/me2me_activity.js ('k') | remoting/webapp/crd/js/smart_reconnector.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698