Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1082313002: Fixing a typo which caused OverscrollNavigationOverlay to be created even when disabled. (Closed)

Created:
5 years, 8 months ago by mfomitchev
Modified:
5 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing a typo which caused OverscrollNavigationOverlay to be created even when disabled. BUG=NONE Committed: https://crrev.com/ae86c87f5709af909aa5cbdf1857f567c2ea8297 Cr-Commit-Position: refs/heads/master@{#325124}

Patch Set 1 #

Patch Set 2 : Removed unwanted change. #

Total comments: 1

Patch Set 3 : Fixed missing {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mfomitchev
5 years, 8 months ago (2015-04-14 19:09:10 UTC) #2
sadrul
Is this something you think we should have tests for? https://codereview.chromium.org/1082313002/diff/20001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://codereview.chromium.org/1082313002/diff/20001/content/browser/web_contents/web_contents_view_aura.cc#newcode949 ...
5 years, 8 months ago (2015-04-14 19:16:39 UTC) #3
mfomitchev
On 2015/04/14 19:16:39, sadrul wrote: > Is this something you think we should have tests ...
5 years, 8 months ago (2015-04-14 19:30:27 UTC) #4
sadrul
lgtm
5 years, 8 months ago (2015-04-14 19:36:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082313002/40001
5 years, 8 months ago (2015-04-14 19:53:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-14 21:28:15 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 21:29:21 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae86c87f5709af909aa5cbdf1857f567c2ea8297
Cr-Commit-Position: refs/heads/master@{#325124}

Powered by Google App Engine
This is Rietveld 408576698