content/browser/web_contents/web_contents_view_aura.cc - Issue 1082313002: Fixing a typo which caused OverscrollNavigationOverlay to be created even when disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 1082313002: Fixing a typo which caused OverscrollNavigationOverlay to be created even when disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed missing {} Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_view_aura.cc

diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc

index ce104f21d7fba7a341dd3bc94791d8f7815d4801..8ce4de0148d5dfde6d2bbc24769811c72e4fae80 100644

--- a/content/browser/web_contents/web_contents_view_aura.cc

+++ b/content/browser/web_contents/web_contents_view_aura.cc

@@ -946,9 +946,9 @@ void WebContentsViewAura::SetOverscrollControllerEnabled(bool enabled) {

InstallOverscrollControllerDelegate(view);

}

- if (!enabled)

+ if (!enabled) {

navigation_overlay_.reset();

- if (!navigation_overlay_) {

+ } else if (!navigation_overlay_) {

navigation_overlay_.reset(

new OverscrollNavigationOverlay(web_contents_, window_.get()));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »