Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7708)

Unified Diff: chrome/browser/ui/webui/extensions/extension_error_handler.cc

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More test magic Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_error_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_error_handler.cc b/chrome/browser/ui/webui/extensions/extension_error_handler.cc
index 94ccb1cecf2898ac04401e4df66fe2faa34852fb..270bd50d3d38e179db3832ee522d88ec8859765f 100644
--- a/chrome/browser/ui/webui/extensions/extension_error_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_error_handler.cc
@@ -197,13 +197,6 @@ void ExtensionErrorHandler::HandleOpenDevTools(const base::ListValue* args) {
if (!rvh)
return;
- // Check if we already have an inspector for the given RenderViewHost. If not,
- // create one.
- DevToolsWindow* window =
- DevToolsWindow::GetInstanceForInspectedRenderViewHost(rvh);
- if (!window)
- window = DevToolsWindow::OpenDevToolsWindow(rvh);
-
// If we include a url, we should inspect it specifically (and not just the
// render view).
base::string16 url;
@@ -216,8 +209,10 @@ void ExtensionErrorHandler::HandleOpenDevTools(const base::ListValue* args) {
// Line/column numbers are reported in display-friendly 1-based numbers,
// but are inspected in zero-based numbers.
- window->Show(
+ DevToolsWindow::OpenDevToolsWindow(rvh,
DevToolsToggleAction::Reveal(url, line_number - 1, column_number - 1));
+ } else {
+ DevToolsWindow::OpenDevToolsWindow(rvh);
}
// Once we open the inspector, we focus on the appropriate tab...

Powered by Google App Engine
This is Rietveld 408576698