chrome/browser/ui/views/extensions/extension_popup.cc - Issue 108213012: [DevTools] Remove dock side knowledge from browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More test magic Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/extension_popup.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc

index 3afafb1e3179ee00db0a351d69f3adff0e64dbaf..ea02358cdc1697ea8dde5f97cd6fc2b509e92359 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup.cc

@@ -253,8 +253,7 @@ void ExtensionPopup::ShowBubble() {

host()->host_contents()->GetView()->Focus();

if (inspect_with_devtools_) {

- DevToolsWindow::ToggleDevToolsWindow(host()->render_view_host(),

- true,

+ DevToolsWindow::OpenDevToolsWindow(host()->render_view_host(),

DevToolsToggleAction::ShowConsole());

}