[DevTools] Remove dock side knowledge from browser.

chrome/browser/ui/cocoa/view_id_util_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/bookmarks/bookmark_test_helpers.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
+#include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/view_id_util.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "extensions/common/switches.h"
@@ skipping 17 matching lines @@
     NSView* view = view_id_util::GetView(root_window_, view_id);
     EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id;
   }
 
   void DoTest() {
     // Make sure FindBar is created to test
     // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE.
     chrome::ShowFindBar(browser());
 
     // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
-    browser()->profile()->GetPrefs()->SetString(prefs::kDevToolsDockSide,
-                                                "dock_bottom");
-    chrome::ToggleDevToolsWindow(browser(), DevToolsToggleAction::Inspect());
+    DevToolsWindow* devtools = DevToolsWindow::ToggleDevToolsWindow(
+        browser(), DevToolsToggleAction::Inspect());
+    devtools->SetIsDockedAndShowImmediatelyForTest(true);

[pfeldman, 2014/01/09 12:52:01]

Could you inline the one above into this method to minimize the call-sites
impact?

[dgozman, 2014/01/14 15:26:17]

Done.

 
     // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
     browser()->window()->GetDownloadShelf()->Show();
 
     // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
     BookmarkModel* bookmark_model =
         BookmarkModelFactory::GetForProfile(browser()->profile());
     if (bookmark_model) {
       if (!bookmark_model->loaded())
         test::WaitForBookmarkModelToLoad(bookmark_model);
@@ skipping 51 matching lines @@
     // VIEW_ID_TAB_LAST should always be available.
     CheckViewID(VIEW_ID_TAB_LAST, true);
   }
 
   // Open the 11th tab.
   browser()->OpenURL(OpenURLParams(
       GURL(content::kAboutBlankURL), Referrer(), NEW_BACKGROUND_TAB,
       content::PAGE_TRANSITION_TYPED, false));
   CheckViewID(VIEW_ID_TAB_LAST, true);
 }