Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2707)

Unified Diff: build/common.gypi

Issue 1082123003: Rename USE_NSS to USE_NSS_CERTS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-nss-certs
Patch Set: long line Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5dfddc7d19e4ee0f2cba074a750a137daee203a0..8263e6f17ddef7c5b04271389024730de6cf30e7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2998,8 +2998,7 @@
'defines': ['USE_GLIB=1'],
}],
['<(use_nss_certs)==1 and >(nacl_untrusted_build)==0', {
- # TODO(davidben): Rename this to USE_NSS_CERTS. https://crbug.com/462040
- 'defines': ['USE_NSS=1'],
+ 'defines': ['USE_NSS_CERTS=1'],
Nico 2015/04/16 16:33:11 If you felt cautious, you could define both in thi
davidben 2015/04/16 18:32:01 Yeah, that's a good idea. I think even just the re
}],
['<(chromeos)==1 and >(nacl_untrusted_build)==0', {
'defines': ['OS_CHROMEOS=1'],

Powered by Google App Engine
This is Rietveld 408576698