Rename USE_NSS to USE_NSS_CERTS.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 2980 matching lines @@
       ['>(nacl_untrusted_build)==1', {
         'defines': [
           'USE_OPENSSL=1',
           'USE_OPENSSL_CERTS=1',
         ],
       }],
       ['<(use_glib)==1 and >(nacl_untrusted_build)==0', {
         'defines': ['USE_GLIB=1'],
       }],
       ['<(use_nss_certs)==1 and >(nacl_untrusted_build)==0', {
-        # TODO(davidben): Rename this to USE_NSS_CERTS. https://crbug.com/462040
-        'defines': ['USE_NSS=1'],
+        'defines': ['USE_NSS_CERTS=1'],

[Nico, 2015/04/16 16:33:11]

If you felt cautious, you could define both in this CL and then reland the
removal of the USE_NSS define in a separate CL. If you need to revert, you would
have less churn then.

[davidben, 2015/04/16 18:32:01]

Yeah, that's a good idea. I think even just the rename here will cause a little
bit of churn. There's one place I found where CrOS has to manually set all the
OS_FOO and USE_FOO flags. But I guess they'll notice a build failure and sort it
out.

Revised plan: I'll still send the PSA when this lands so downstreams can rename
as soon as they take this pair of CLs without making automated rolls sad. Then
I'll land the removal of the deprecated ones a day or two later.

       }],
       ['<(chromeos)==1 and >(nacl_untrusted_build)==0', {
         'defines': ['OS_CHROMEOS=1'],
       }],
       ['enable_wexit_time_destructors==1 and OS!="win"', {
         # TODO: Enable on Windows too, http://crbug.com/404525
         'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
       }],
       ['chromium_code==0', {
         'conditions': [
@@ skipping 3070 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }