Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(125)

Issue 10821086: Fix bug in SpdySession (Closed)

Created:
7 years, 3 months ago by Ryan Hamilton
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix bug in SpdySession where map.erase() was called on an iterator when the underlying map had changed, making the iterator invalid. BUG=139518 TEST=SpdySessionSpdy*Test.CloseSessionWithTwoCreatedStreams Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149071

Patch Set 1 #

Patch Set 2 : Complete #

Total comments: 12

Patch Set 3 : Fix sleevi comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -15 lines) Patch
M net/spdy/spdy_session.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_spdy2_unittest.cc View 1 2 3 chunks +133 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_spdy3_unittest.cc View 1 2 4 chunks +142 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
drive by checks http://codereview.chromium.org/10821086/diff/6001/net/spdy/spdy_session_spdy2_unittest.cc File net/spdy/spdy_session_spdy2_unittest.cc (right): http://codereview.chromium.org/10821086/diff/6001/net/spdy/spdy_session_spdy2_unittest.cc#newcode1389 net/spdy/spdy_session_spdy2_unittest.cc:1389: namespace { drive by nit: According ...
7 years, 3 months ago (2012-07-30 06:36:15 UTC) #1
Ryan Hamilton
http://codereview.chromium.org/10821086/diff/6001/net/spdy/spdy_session_spdy2_unittest.cc File net/spdy/spdy_session_spdy2_unittest.cc (right): http://codereview.chromium.org/10821086/diff/6001/net/spdy/spdy_session_spdy2_unittest.cc#newcode1389 net/spdy/spdy_session_spdy2_unittest.cc:1389: namespace { On 2012/07/30 06:36:15, Ryan Sleevi wrote: > ...
7 years, 3 months ago (2012-07-30 16:21:13 UTC) #2
ramant (doing other things)
lgtm
7 years, 3 months ago (2012-07-30 21:20:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10821086/11001
7 years, 3 months ago (2012-07-30 21:27:29 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2012-07-30 23:18:33 UTC) #5
Change committed as 149071

Powered by Google App Engine
This is Rietveld 408576698