Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 108203005: Remove ancestor walk for non-SVG RenderObjects in willBeRemovedFromTree() (Closed)

Created:
7 years ago by pdr.
Modified:
7 years ago
Reviewers:
schenney, esprehn, fmalita_google_do_not_use, ojan
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Remove ancestor walk for non-SVG RenderObjects in willBeRemovedFromTree() This patch removes the recursive setNeedsBoundariesUpdate() calls that were done in RenderObject::willBeRemovedFromTree(). This patch has three main components: 1) The virtual RenderObject::needsBoundariesUpdate() has been removed as it was never called. 2) The virtual RenderObject::isSVG() has been added for determining whether a RenderObject is an SVG renderer. All SVG renderers have been updated to return true for isSVG(). See the following diagram for more information: https://docs.google.com/a/chromium.org/drawings/d/1nayJX5XcclYj_-blbVuakVNjVWdRAzC5i5s6xBeHfzA/edit 3) RenderObject::willBeRemovedFromTree() now only calls setNeedsBoundariesUpdate() if the parent renderer is SVG. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164056

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M Source/core/rendering/RenderObject.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
7 years ago (2013-12-17 03:40:52 UTC) #1
ojan
lgtm
7 years ago (2013-12-18 00:17:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/108203005/20001
7 years ago (2013-12-18 00:17:48 UTC) #3
esprehn
amazing! Thank you. lgtm
7 years ago (2013-12-18 00:24:43 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-18 04:42:41 UTC) #5
Message was sent while issue was closed.
Change committed as 164056

Powered by Google App Engine
This is Rietveld 408576698