Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 108203005: Remove ancestor walk for non-SVG RenderObjects in willBeRemovedFromTree() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Minor cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 InsideInFlowThread = 2, 422 InsideInFlowThread = 2,
423 }; 423 };
424 424
425 void setFlowThreadStateIncludingDescendants(FlowThreadState); 425 void setFlowThreadStateIncludingDescendants(FlowThreadState);
426 426
427 FlowThreadState flowThreadState() const { return m_bitfields.flowThreadState (); } 427 FlowThreadState flowThreadState() const { return m_bitfields.flowThreadState (); }
428 void setFlowThreadState(FlowThreadState state) { m_bitfields.setFlowThreadSt ate(state); } 428 void setFlowThreadState(FlowThreadState state) { m_bitfields.setFlowThreadSt ate(state); }
429 429
430 // FIXME: Until all SVG renders can be subclasses of RenderSVGModelObject we have 430 // FIXME: Until all SVG renders can be subclasses of RenderSVGModelObject we have
431 // to add SVG renderer methods to RenderObject with an ASSERT_NOT_REACHED() default implementation. 431 // to add SVG renderer methods to RenderObject with an ASSERT_NOT_REACHED() default implementation.
432 virtual bool isSVG() const { return false; }
432 virtual bool isSVGRoot() const { return false; } 433 virtual bool isSVGRoot() const { return false; }
433 virtual bool isSVGContainer() const { return false; } 434 virtual bool isSVGContainer() const { return false; }
434 virtual bool isSVGTransformableContainer() const { return false; } 435 virtual bool isSVGTransformableContainer() const { return false; }
435 virtual bool isSVGViewportContainer() const { return false; } 436 virtual bool isSVGViewportContainer() const { return false; }
436 virtual bool isSVGGradientStop() const { return false; } 437 virtual bool isSVGGradientStop() const { return false; }
437 virtual bool isSVGHiddenContainer() const { return false; } 438 virtual bool isSVGHiddenContainer() const { return false; }
438 virtual bool isSVGPath() const { return false; } 439 virtual bool isSVGPath() const { return false; }
439 virtual bool isSVGShape() const { return false; } 440 virtual bool isSVGShape() const { return false; }
440 virtual bool isSVGText() const { return false; } 441 virtual bool isSVGText() const { return false; }
441 virtual bool isSVGTextPath() const { return false; } 442 virtual bool isSVGTextPath() const { return false; }
442 virtual bool isSVGInline() const { return false; } 443 virtual bool isSVGInline() const { return false; }
443 virtual bool isSVGInlineText() const { return false; } 444 virtual bool isSVGInlineText() const { return false; }
444 virtual bool isSVGImage() const { return false; } 445 virtual bool isSVGImage() const { return false; }
445 virtual bool isSVGForeignObject() const { return false; } 446 virtual bool isSVGForeignObject() const { return false; }
446 virtual bool isSVGResourceContainer() const { return false; } 447 virtual bool isSVGResourceContainer() const { return false; }
447 virtual bool isSVGResourceFilter() const { return false; } 448 virtual bool isSVGResourceFilter() const { return false; }
448 virtual bool isSVGResourceFilterPrimitive() const { return false; } 449 virtual bool isSVGResourceFilterPrimitive() const { return false; }
449 450
450 // FIXME: Those belong into a SVG specific base-class for all renderers (see above) 451 // FIXME: Those belong into a SVG specific base-class for all renderers (see above)
451 // Unfortunately we don't have such a class yet, because it's not possible f or all renderers 452 // Unfortunately we don't have such a class yet, because it's not possible f or all renderers
452 // to inherit from RenderSVGObject -> RenderObject (some need RenderBlock in heritance for instance) 453 // to inherit from RenderSVGObject -> RenderObject (some need RenderBlock in heritance for instance)
453 virtual void setNeedsTransformUpdate() { } 454 virtual void setNeedsTransformUpdate() { }
454 virtual void setNeedsBoundariesUpdate(); 455 virtual void setNeedsBoundariesUpdate();
455 virtual bool needsBoundariesUpdate() { return false; }
456 456
457 // Per SVG 1.1 objectBoundingBox ignores clipping, masking, filter effects, opacity and stroke-width. 457 // Per SVG 1.1 objectBoundingBox ignores clipping, masking, filter effects, opacity and stroke-width.
458 // This is used for all computation of objectBoundingBox relative units and by SVGLocatable::getBBox(). 458 // This is used for all computation of objectBoundingBox relative units and by SVGLocatable::getBBox().
459 // NOTE: Markers are not specifically ignored here by SVG 1.1 spec, but we i gnore them 459 // NOTE: Markers are not specifically ignored here by SVG 1.1 spec, but we i gnore them
460 // since stroke-width is ignored (and marker size can depend on stroke-width ). 460 // since stroke-width is ignored (and marker size can depend on stroke-width ).
461 // objectBoundingBox is returned local coordinates. 461 // objectBoundingBox is returned local coordinates.
462 // The name objectBoundingBox is taken from the SVG 1.1 spec. 462 // The name objectBoundingBox is taken from the SVG 1.1 spec.
463 virtual FloatRect objectBoundingBox() const; 463 virtual FloatRect objectBoundingBox() const;
464 virtual FloatRect strokeBoundingBox() const; 464 virtual FloatRect strokeBoundingBox() const;
465 465
(...skipping 956 matching lines...) Expand 10 before | Expand all | Expand 10 after
1422 void showTree(const WebCore::RenderObject*); 1422 void showTree(const WebCore::RenderObject*);
1423 void showLineTree(const WebCore::RenderObject*); 1423 void showLineTree(const WebCore::RenderObject*);
1424 void showRenderTree(const WebCore::RenderObject* object1); 1424 void showRenderTree(const WebCore::RenderObject* object1);
1425 // We don't make object2 an optional parameter so that showRenderTree 1425 // We don't make object2 an optional parameter so that showRenderTree
1426 // can be called from gdb easily. 1426 // can be called from gdb easily.
1427 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1427 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1428 1428
1429 #endif 1429 #endif
1430 1430
1431 #endif // RenderObject_h 1431 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698