Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1081953004: Add tests for console messages of waitUntil() and respondWith() (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto
Modified:
5 years, 8 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for console messages of waitUntil() and respondWith() This adds browser tests that verify console message logged when a promise passed to waitUntil() or respondWith() is rejected. These tests are here because console outputs from SWs aren't testable with layout tests (crbug.com/456708). BUG=359423 Committed: https://crrev.com/7f64887fa4067a08766179a313b623115b1e8f07 Cr-Commit-Position: refs/heads/master@{#325383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 3 chunks +86 lines, -0 lines 0 comments Download
A + content/test/data/service_worker/fetch_event_rejected.js View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/service_worker/worker_install_rejected.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
5 years, 8 months ago (2015-04-15 09:30:38 UTC) #2
horo
lgtm
5 years, 8 months ago (2015-04-16 01:43:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081953004/1
5 years, 8 months ago (2015-04-16 01:51:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 02:53:50 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 02:54:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f64887fa4067a08766179a313b623115b1e8f07
Cr-Commit-Position: refs/heads/master@{#325383}

Powered by Google App Engine
This is Rietveld 408576698