Installer: adding ResolveShortcutProperties(); updating shortcut icons during shortcut migration.

chrome/installer/util/shell_util.h

Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 9286ae225189856d7aed6cd53c5bc99644f01373..1f4e0a3908c60424122729c6f6c4cdb0351d0c99 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -537,6 +537,21 @@ class ShellUtil {
       const base::FilePath& target_exe,
       const ShellUtil::ShortcutProperties& properties);
 
+  // Updates the target of all shortcuts in |location| that satisfie the

[gab, 2013/12/23 14:25:01]

s/satisfie/satisfy

[huangs, 2013/12/30 20:15:10]

Done.

+  // following:
+  // - the shortcut's original target is |old_target_exe|,
+  // - the original arguments are non-empty.
+  // If the shortcut's icon points to |old_target_exe|, then it also gets
+  // redirected to |new_target_exe|.
+  // Returns true if all updates to matching shortcuts are successful, including
+  // the vacuous case where no matching shortcuts are found.
+  static bool RetargetShortcutsWithArgs(

[gab, 2013/12/23 14:25:01]

Add tests for this method; you can most likely re-use most of the tests from
UpdateShortcutWithArgs.

[huangs, 2013/12/30 20:15:10]

Done.

+      ShellUtil::ShortcutLocation location,
+      BrowserDistribution* dist,
+      ShellChange level,
+      const base::FilePath& old_target_exe,
+      const base::FilePath& new_target_exe);
+
   // Sets |suffix| to the base 32 encoding of the md5 hash of this user's sid
   // preceded by a dot.
   // This is guaranteed to be unique on the machine and 27 characters long