Installer: adding ResolveShortcutProperties(); updating shortcut icons during shortcut migration.

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 512 matching lines @@
                               BrowserDistribution* dist,
                               ShellChange level,
                               const base::FilePath& target_exe);
 
   // Applies the updates in |properties| to all matching shortcuts in
   // |location|, i.e.:
   // - the shortcut's original target is |target_exe|,
   // - the original arguments are non-empty.
   // Returns true if all updates to matching shortcuts are successful, including
   // the vacuous case where no matching shortcuts are found.
   static bool UpdateShortcutsWithArgs(

[gab, 2013/12/23 14:25:01]

I don't think this is used anymore, remove it, we can always bring it back later
if it becomes useful again.

[huangs, 2013/12/30 20:15:10]

Removed, along with ShortcutOpUpdate() in the .cc file.

       ShellUtil::ShortcutLocation location,
       BrowserDistribution* dist,
       ShellChange level,
       const base::FilePath& target_exe,
       const ShellUtil::ShortcutProperties& properties);
 
+  // Updates the target of all shortcuts in |location| that satisfie the

[gab, 2013/12/23 14:25:01]

s/satisfie/satisfy

[huangs, 2013/12/30 20:15:10]

Done.

+  // following:
+  // - the shortcut's original target is |old_target_exe|,
+  // - the original arguments are non-empty.
+  // If the shortcut's icon points to |old_target_exe|, then it also gets
+  // redirected to |new_target_exe|.
+  // Returns true if all updates to matching shortcuts are successful, including
+  // the vacuous case where no matching shortcuts are found.
+  static bool RetargetShortcutsWithArgs(

[gab, 2013/12/23 14:25:01]

Add tests for this method; you can most likely re-use most of the tests from
UpdateShortcutWithArgs.

[huangs, 2013/12/30 20:15:10]

Done.

+      ShellUtil::ShortcutLocation location,
+      BrowserDistribution* dist,
+      ShellChange level,
+      const base::FilePath& old_target_exe,
+      const base::FilePath& new_target_exe);
+
   // Sets |suffix| to the base 32 encoding of the md5 hash of this user's sid
   // preceded by a dot.
   // This is guaranteed to be unique on the machine and 27 characters long
   // (including the '.').
   // This suffix is then meant to be added to all registration that may conflict
   // with another user-level Chrome install.
   // Note that prior to Chrome 21, the suffix registered used to be the user's
   // username (see GetOldUserSpecificRegistrySuffix() below). We still honor old
   // installs registered that way, but it was wrong because some of the
   // characters allowed in a username are not allowed in a ProgId.
@@ skipping 16 matching lines @@
   // required by the base32 standard for inputs that aren't a multiple of 5
   // bytes.
   static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_