Fixing opacity for browser frame window on ASH/Windows.

ash/shell/content_client/shell_browser_main_parts.cc

Index: ash/shell/content_client/shell_browser_main_parts.cc
diff --git a/ash/shell/content_client/shell_browser_main_parts.cc b/ash/shell/content_client/shell_browser_main_parts.cc
index 478453de02044d110ae4dad749384ba38268744f..4a8128bcaf324f1be75860d6030d83e387613e74 100644
--- a/ash/shell/content_client/shell_browser_main_parts.cc
+++ b/ash/shell/content_client/shell_browser_main_parts.cc
@@ -57,16 +57,19 @@ class ShellViewsDelegate : public views::TestViewsDelegate {
       views::Widget* widget) OVERRIDE {
     return ash::Shell::GetInstance()->CreateDefaultNonClientFrameView(widget);
   }
-  virtual bool UseTransparentWindows() const OVERRIDE {
-    // Ash uses transparent window frames.
-    return true;
-  }
   virtual void OnBeforeWidgetInit(
       views::Widget::InitParams* params,
       views::internal::NativeWidgetDelegate* delegate) OVERRIDE {
     if (params->native_widget)
       return;
 
+    if (params->opacity == InitParams::INFER_OPACITY) {
+      if (use_transparent_windows_)

[sky, 2013/12/12 23:58:14]

Where does use_transperent_windows_ come from? Seems like you want this to be
true (based on code your nuking). Also, shouldn't this be before the early
return on 64?

[Shrikant Kelkar, 2013/12/17 07:06:21]

TestViewsDelegate defines a metod SetUseTransparentWindows for unit testing,
that's where this variable gets set.

+        params->opacity = InitParams::TRANSLUCENT_WINDOW;
+      else
+        params->opacity = InitParams::OPAQUE_WINDOW;
+    }
+
     if (!params->parent && !params->context && params->top_level)
       params->context = Shell::GetPrimaryRootWindow();
   }