Fixing opacity for browser frame window on ASH/Windows.

ash/shell/content_client/shell_browser_main_parts.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shell/content_client/shell_browser_main_parts.h"
 
 #include "ash/ash_switches.h"
 #include "ash/desktop_background/desktop_background_controller.h"
 #include "ash/shell.h"
 #include "ash/shell/shell_delegate_impl.h"
@@ skipping 39 matching lines @@
 class ShellViewsDelegate : public views::TestViewsDelegate {
  public:
   ShellViewsDelegate() {}
   virtual ~ShellViewsDelegate() {}
 
   // Overridden from views::TestViewsDelegate:
   virtual views::NonClientFrameView* CreateDefaultNonClientFrameView(
       views::Widget* widget) OVERRIDE {
     return ash::Shell::GetInstance()->CreateDefaultNonClientFrameView(widget);
   }
-  virtual bool UseTransparentWindows() const OVERRIDE {
-    // Ash uses transparent window frames.
-    return true;
-  }
   virtual void OnBeforeWidgetInit(
       views::Widget::InitParams* params,
       views::internal::NativeWidgetDelegate* delegate) OVERRIDE {
     if (params->native_widget)
       return;
 
+    if (params->opacity == InitParams::INFER_OPACITY) {
+      if (use_transparent_windows_)

[sky, 2013/12/12 23:58:14]

Where does use_transperent_windows_ come from? Seems like you want this to be
true (based on code your nuking). Also, shouldn't this be before the early
return on 64?

[Shrikant Kelkar, 2013/12/17 07:06:21]

TestViewsDelegate defines a metod SetUseTransparentWindows for unit testing,
that's where this variable gets set.

+        params->opacity = InitParams::TRANSLUCENT_WINDOW;
+      else
+        params->opacity = InitParams::OPAQUE_WINDOW;
+    }
+
     if (!params->parent && !params->context && params->top_level)
       params->context = Shell::GetPrimaryRootWindow();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellViewsDelegate);
 };
 
 }  // namespace
 
@@ skipping 82 matching lines @@
   browser_context_.reset();
 }
 
 bool ShellBrowserMainParts::MainMessageLoopRun(int* result_code) {
   base::MessageLoopForUI::current()->Run();
   return true;
 }
 
 }  // namespace shell
 }  // namespace ash