Fixing opacity for browser frame window on ASH/Windows.

chrome/browser/ui/views/frame/browser_frame.cc

Index: chrome/browser/ui/views/frame/browser_frame.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame.cc b/chrome/browser/ui/views/frame/browser_frame.cc
index 595266846421ea24fd7b896aff6dd27351ebfa00..3912b08a46017baa47e2cae9e6a305d56b4fe733 100644
--- a/chrome/browser/ui/views/frame/browser_frame.cc
+++ b/chrome/browser/ui/views/frame/browser_frame.cc
@@ -96,6 +96,13 @@ void BrowserFrame::InitBrowserFrame() {
   if (browser_view_->browser()->host_desktop_type() ==
       chrome::HOST_DESKTOP_TYPE_ASH || chrome::ShouldOpenAshOnStartup()) {
     params.context = ash::Shell::GetPrimaryRootWindow();
+
+#if defined(OS_WIN)
+    // If this window is under ASH on Windows, we need it to be translucent.
+    // TODO(shrikant): Instead of #if, this logic can possibly be moved to

[scottmg, 2013/12/06 22:00:17]

I think just delete this TODO.

[sky, 2013/12/11 21:17:28]

Ah, that's right. In that case isn't the better fix to pass context as the TODO
says in that function so that you don't need an ifdef here?

[Shrikant Kelkar, 2013/12/11 21:58:37]

Please correct me, but as I understand host_desktop_type is not easily
accessible or comes late in the picture in terms of Widget initialization or
creation. In this particular case of ASH/Windows host_desktop_type is required
to determine if we want translucent or opaque frame window.

+    // platform specific NativeBrowserFrame by extending interface definition.
+    params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
+#endif
   }
 #endif