Fixing opacity for browser frame window on ASH/Windows.

chrome/browser/ui/views/frame/browser_frame.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 
 #include "ash/shell.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
@@ skipping 78 matching lines @@
     // Typed panel/popup can only return a size once the widget has been
     // created.
     chrome::GetSavedWindowBoundsAndShowState(browser_view_->browser(),
                                              &params.bounds,
                                              &params.show_state);
   }
 #if defined(USE_ASH)
   if (browser_view_->browser()->host_desktop_type() ==
       chrome::HOST_DESKTOP_TYPE_ASH || chrome::ShouldOpenAshOnStartup()) {
     params.context = ash::Shell::GetPrimaryRootWindow();
+
+#if defined(OS_WIN)
+    // If this window is under ASH on Windows, we need it to be translucent.
+    // TODO(shrikant): Instead of #if, this logic can possibly be moved to

[scottmg, 2013/12/06 22:00:17]

I think just delete this TODO.

[sky, 2013/12/11 21:17:28]

Ah, that's right. In that case isn't the better fix to pass context as the TODO
says in that function so that you don't need an ifdef here?

[Shrikant Kelkar, 2013/12/11 21:58:37]

Please correct me, but as I understand host_desktop_type is not easily
accessible or comes late in the picture in terms of Widget initialization or
creation. In this particular case of ASH/Windows host_desktop_type is required
to determine if we want translucent or opaque frame window.

+    // platform specific NativeBrowserFrame by extending interface definition.
+    params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
+#endif
   }
 #endif
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // Set up a custom WM_CLASS for some sorts of window types. This allows
   // task switchers in X11 environments to distinguish between main browser
   // windows and e.g app windows.
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   const Browser& browser = *browser_view_->browser();
   params.wm_class_class = ShellIntegrationLinux::GetProgramClassName();
@@ skipping 154 matching lines @@
 
 NewAvatarButton* BrowserFrame::GetNewAvatarMenuButton() {
   return browser_frame_view_->new_avatar_button();
 }
 
 #if !defined(OS_WIN) || defined(USE_AURA)
 bool BrowserFrame::ShouldLeaveOffsetNearTopBorder() {
   return !IsMaximized();
 }
 #endif  // OS_WIN