Fixing opacity for browser frame window on ASH/Windows.

chrome/browser/ui/views/frame/browser_frame.cc

Index: chrome/browser/ui/views/frame/browser_frame.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame.cc b/chrome/browser/ui/views/frame/browser_frame.cc
index 595266846421ea24fd7b896aff6dd27351ebfa00..d6794f98e85111d1960b22ddfe0153cc5b09ab4c 100644
--- a/chrome/browser/ui/views/frame/browser_frame.cc
+++ b/chrome/browser/ui/views/frame/browser_frame.cc
@@ -96,6 +96,13 @@ void BrowserFrame::InitBrowserFrame() {
   if (browser_view_->browser()->host_desktop_type() ==
       chrome::HOST_DESKTOP_TYPE_ASH || chrome::ShouldOpenAshOnStartup()) {
     params.context = ash::Shell::GetPrimaryRootWindow();
+
+#if defined(OS_WIN)
+    // If this window is under ASH on Windows. We need it to be Translucent.

[scottmg, 2013/12/06 20:52:00]

nit; "If this window is under ASH on Windows. We need it to be Translucent."

to

"If this window is under ASH on Windows, we need it to be translucent."

[Shrikant Kelkar, 2013/12/06 21:46:50]

Done.

+    // TODO(shrikant): Instead of #if, this logic can possibly be moved to
+    // platform specific NativeBrowserFrame by extending interface definition.
+    params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;

[scottmg, 2013/12/06 20:52:00]

It should ask ChromeViewsDelegate::UseTransparentWindows, right? Can that not be
made to return the right thing?

[Shrikant Kelkar, 2013/12/06 21:46:50]

It doesn't do the right thing as of now for ASH windows (on Windows). We could
place it there but then there is no context and though GetActiveDesktop() is
currently being used in multiple places to derive context, it could potentially
be a problem in future with instances on both sides, Native and ASH.

+#endif
   }
 #endif