Fixing opacity for browser frame window on ASH/Windows.

chrome/browser/ui/views/frame/browser_frame.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 
 #include "ash/shell.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
@@ skipping 78 matching lines @@
     // Typed panel/popup can only return a size once the widget has been
     // created.
     chrome::GetSavedWindowBoundsAndShowState(browser_view_->browser(),
                                              &params.bounds,
                                              &params.show_state);
   }
 #if defined(USE_ASH)
   if (browser_view_->browser()->host_desktop_type() ==
       chrome::HOST_DESKTOP_TYPE_ASH || chrome::ShouldOpenAshOnStartup()) {
     params.context = ash::Shell::GetPrimaryRootWindow();
+
+#if defined(OS_WIN)
+    // If this window is under ASH on Windows. We need it to be Translucent.

[scottmg, 2013/12/06 20:52:00]

nit; "If this window is under ASH on Windows. We need it to be Translucent."

to

"If this window is under ASH on Windows, we need it to be translucent."

[Shrikant Kelkar, 2013/12/06 21:46:50]

Done.

+    // TODO(shrikant): Instead of #if, this logic can possibly be moved to
+    // platform specific NativeBrowserFrame by extending interface definition.
+    params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;

[scottmg, 2013/12/06 20:52:00]

It should ask ChromeViewsDelegate::UseTransparentWindows, right? Can that not be
made to return the right thing?

[Shrikant Kelkar, 2013/12/06 21:46:50]

It doesn't do the right thing as of now for ASH windows (on Windows). We could
place it there but then there is no context and though GetActiveDesktop() is
currently being used in multiple places to derive context, it could potentially
be a problem in future with instances on both sides, Native and ASH.

+#endif
   }
 #endif
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // Set up a custom WM_CLASS for some sorts of window types. This allows
   // task switchers in X11 environments to distinguish between main browser
   // windows and e.g app windows.
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   const Browser& browser = *browser_view_->browser();
   params.wm_class_class = ShellIntegrationLinux::GetProgramClassName();
@@ skipping 154 matching lines @@
 
 NewAvatarButton* BrowserFrame::GetNewAvatarMenuButton() {
   return browser_frame_view_->new_avatar_button();
 }
 
 #if !defined(OS_WIN) || defined(USE_AURA)
 bool BrowserFrame::ShouldLeaveOffsetNearTopBorder() {
   return !IsMaximized();
 }
 #endif  // OS_WIN