Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1081883002: Remove unnecessary options from HTailCallThroughMegamorphicCache (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unnecessary options from HTailCallThroughMegamorphicCache These options were added for a hydrogen code stub version of the VectorIC dispatcher, which was discontinued. R=verwaest@chromium.org BUG= Committed: https://crrev.com/e0844a24d35c03c6971b8beb633c3506c212179a Cr-Commit-Position: refs/heads/master@{#27793}

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -284 lines) Patch
M src/arm/lithium-arm.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +5 lines, -24 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +5 lines, -20 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +3 lines, -52 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +6 lines, -32 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +5 lines, -23 lines 0 comments Download
M src/mips/lithium-mips.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +5 lines, -23 lines 0 comments Download
M src/mips64/lithium-mips64.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +5 lines, -20 lines 0 comments Download
M src/x64/lithium-x64.h View 1 1 chunk +3 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Toon, Here is a nice cleanup CL. Thx for the look, --Michael
5 years, 8 months ago (2015-04-13 14:17:42 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-13 14:28:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081883002/20001
5 years, 8 months ago (2015-04-13 14:39:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-13 16:23:30 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 16:23:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0844a24d35c03c6971b8beb633c3506c212179a
Cr-Commit-Position: refs/heads/master@{#27793}

Powered by Google App Engine
This is Rietveld 408576698