Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 1081883002: Remove unnecessary options from HTailCallThroughMegamorphicCache (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips/lithium-codegen-mips.cc
diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc
index 6293b2cb108a435f45516ecf7d3cda584ee46e41..6431100e5ff2303cca7dedea66389838e373e370 100644
--- a/src/mips/lithium-codegen-mips.cc
+++ b/src/mips/lithium-codegen-mips.cc
@@ -3948,32 +3948,14 @@ void LCodeGen::DoTailCallThroughMegamorphicCache(
Register extra = t1;
Register extra2 = t2;
Register extra3 = t5;
-#ifdef DEBUG
- Register slot = FLAG_vector_ics ? ToRegister(instr->slot()) : no_reg;
- Register vector = FLAG_vector_ics ? ToRegister(instr->vector()) : no_reg;
- DCHECK(!FLAG_vector_ics ||
- !AreAliased(slot, vector, scratch, extra, extra2, extra3));
-#endif
- // Important for the tail-call.
- bool must_teardown_frame = NeedsEagerFrame();
-
- if (!instr->hydrogen()->is_just_miss()) {
- DCHECK(!instr->hydrogen()->is_keyed_load());
-
- // The probe will tail call to a handler if found.
- isolate()->stub_cache()->GenerateProbe(
- masm(), Code::LOAD_IC, instr->hydrogen()->flags(), must_teardown_frame,
- receiver, name, scratch, extra, extra2, extra3);
- }
+ // The probe will tail call to a handler if found.
+ isolate()->stub_cache()->GenerateProbe(
+ masm(), Code::LOAD_IC, instr->hydrogen()->flags(), false, receiver, name,
+ scratch, extra, extra2, extra3);
// Tail call to miss if we ended up here.
- if (must_teardown_frame) __ LeaveFrame(StackFrame::INTERNAL);
- if (instr->hydrogen()->is_keyed_load()) {
- KeyedLoadIC::GenerateMiss(masm());
- } else {
- LoadIC::GenerateMiss(masm());
- }
+ LoadIC::GenerateMiss(masm());
}
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698