Make loading dialog prettier.

Make loading dialog prettier.

Since the width of this dialog is no longer fixed, this CL also updates base.resizeWindowToContent to set the width as well as the height, and adds support for centering.

BUG=b/19796166

Committed: https://crrev.com/9c9f27b5a454bfe763d07c4847235e531c3df200
Cr-Commit-Position: refs/heads/master@{#327160}

[Jamie, 2015-04-23 22:01:30]

jamiewalch@chromium.org changed reviewers:
+ garykac@chromium.org

[Jamie, 2015-04-23 22:01:30]

The images are not ready yet, but I wanted to get the code review done in
parallel.

PTAL.

https://codereview.chromium.org/1081813007/diff/1/remoting/webapp/base/html/m...
File remoting/webapp/base/html/message_window.css (left):

https://codereview.chromium.org/1081813007/diff/1/remoting/webapp/base/html/m...
remoting/webapp/base/html/message_window.css:17: }
This was not used anywhere.

https://codereview.chromium.org/1081813007/diff/1/remoting/webapp/base/js/mes...
File remoting/webapp/base/js/message_window_helper.js (left):

https://codereview.chromium.org/1081813007/diff/1/remoting/webapp/base/js/mes...
remoting/webapp/base/js/message_window_helper.js:286: };
This helper was only used in one place, so wasn't providing a lot of value. I
could have modified it to take html and frame parameters, but removing it seemed
a better option.

[Jamie, 2015-04-24 18:43:52]

Ping

[garykac, 2015-04-27 21:18:06]

lgtm with comments

https://codereview.chromium.org/1081813007/diff/20001/remoting/app_remoting_w...
File remoting/app_remoting_webapp_build.gypi (right):

https://codereview.chromium.org/1081813007/diff/20001/remoting/app_remoting_w...
remoting/app_remoting_webapp_build.gypi:194: '--js',
'<@(remoting_webapp_message_window_html_all_js_files)',
Can you add a comment here mentioning that we're purposefully using the list of
message_window_html files since the loading_window is just a special case of
message_window? Even though there's a comment in the gypi, I think it would be
useful here as well.

Every time I see this, it looks like a typo and I have to remind myself why the
--js files are not _loading_window_.

https://codereview.chromium.org/1081813007/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/base.js (right):

https://codereview.chromium.org/1081813007/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/base.js:795: var newWidth =
document.documentElement.scrollWidth + borderX;
The width is now being calculated differently. Can you call that out in the cl
description?

[Jamie, 2015-04-27 21:29:28]

FYI

https://codereview.chromium.org/1081813007/diff/20001/remoting/app_remoting_w...
File remoting/app_remoting_webapp_build.gypi (right):

https://codereview.chromium.org/1081813007/diff/20001/remoting/app_remoting_w...
remoting/app_remoting_webapp_build.gypi:194: '--js',
'<@(remoting_webapp_message_window_html_all_js_files)',
On 2015/04/27 21:18:06, garykac wrote:
> Can you add a comment here mentioning that we're purposefully using the list
of
> message_window_html files since the loading_window is just a special case of
> message_window? Even though there's a comment in the gypi, I think it would be
> useful here as well.
> 
> Every time I see this, it looks like a typo and I have to remind myself why
the
> --js files are not _loading_window_.

Done.

https://codereview.chromium.org/1081813007/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/base.js (right):

https://codereview.chromium.org/1081813007/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/base.js:795: var newWidth =
document.documentElement.scrollWidth + borderX;
On 2015/04/27 21:18:06, garykac wrote:
> The width is now being calculated differently. Can you call that out in the cl
> description?

Done.

[Jamie, 2015-04-27 21:29:31]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-04-27 21:29:31]

The patchset sent to the CQ was uploaded after l-g-t-m from garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1081813007/#ps40001
(title: "Reviewer feedback.")

[commit-bot: I haz the power, 2015-04-27 21:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1081813007/40001

[commit-bot: I haz the power, 2015-04-27 22:43:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-27 22:43:55]

Patchset 3 (id:??) landed as
https://crrev.com/9c9f27b5a454bfe763d07c4847235e531c3df200
Cr-Commit-Position: refs/heads/master@{#327160}