Source/core/layout/LayoutBox.h - Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.h

Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: remove flexbox change Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutBox.h

diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h

index 874c525f13fede9cbfdcd8a6947cfb56b41d2e57..f7c00b277bb01d5b29b501a7cfc5b94563afca31 100644

--- a/Source/core/layout/LayoutBox.h

+++ b/Source/core/layout/LayoutBox.h

@@ -533,8 +533,7 @@ public:

virtual LayoutUnit computeReplacedLogicalHeight() const;

bool hasDefiniteLogicalWidth() const;

- bool percentageLogicalHeightIsResolvable() const;

- bool hasDefiniteLogicalHeight() const;

+ bool logicalHeightIsDefinite(const Length& height) const;

LayoutUnit computePercentageLogicalHeight(const Length& height) const;

// Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.)

« no previous file with comments | « no previous file | Source/core/layout/LayoutBox.cpp » ('j') | Source/core/layout/LayoutBox.cpp » ('J')