Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/layout/LayoutBox.h

Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove flexbox change Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/layout/LayoutBox.cpp » ('j') | Source/core/layout/LayoutBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 LayoutUnit computeContentAndScrollbarLogicalHeightUsing(SizeType, const Leng th& height, LayoutUnit intrinsicContentHeight) const; 526 LayoutUnit computeContentAndScrollbarLogicalHeightUsing(SizeType, const Leng th& height, LayoutUnit intrinsicContentHeight) const;
527 LayoutUnit computeReplacedLogicalWidthUsing(SizeType, const Length& width) c onst; 527 LayoutUnit computeReplacedLogicalWidthUsing(SizeType, const Length& width) c onst;
528 LayoutUnit computeReplacedLogicalWidthRespectingMinMaxWidth(LayoutUnit logic alWidth, ShouldComputePreferred = ComputeActual) const; 528 LayoutUnit computeReplacedLogicalWidthRespectingMinMaxWidth(LayoutUnit logic alWidth, ShouldComputePreferred = ComputeActual) const;
529 LayoutUnit computeReplacedLogicalHeightUsing(SizeType, const Length& height) const; 529 LayoutUnit computeReplacedLogicalHeightUsing(SizeType, const Length& height) const;
530 LayoutUnit computeReplacedLogicalHeightRespectingMinMaxHeight(LayoutUnit log icalHeight) const; 530 LayoutUnit computeReplacedLogicalHeightRespectingMinMaxHeight(LayoutUnit log icalHeight) const;
531 531
532 virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = Com puteActual) const; 532 virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = Com puteActual) const;
533 virtual LayoutUnit computeReplacedLogicalHeight() const; 533 virtual LayoutUnit computeReplacedLogicalHeight() const;
534 534
535 bool hasDefiniteLogicalWidth() const; 535 bool hasDefiniteLogicalWidth() const;
536 bool percentageLogicalHeightIsResolvable() const; 536 bool logicalHeightIsDefinite(const Length& height) const;
537 bool hasDefiniteLogicalHeight() const;
538 LayoutUnit computePercentageLogicalHeight(const Length& height) const; 537 LayoutUnit computePercentageLogicalHeight(const Length& height) const;
539 538
540 // Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.) 539 // Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.)
541 LayoutUnit availableLogicalWidth() const { return contentLogicalWidth(); } 540 LayoutUnit availableLogicalWidth() const { return contentLogicalWidth(); }
542 LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const; 541 LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const;
543 LayoutUnit availableLogicalHeightUsing(const Length&, AvailableLogicalHeight Type) const; 542 LayoutUnit availableLogicalHeightUsing(const Length&, AvailableLogicalHeight Type) const;
544 543
545 // There are a few cases where we need to refer specifically to the availabl e physical width and available physical height. 544 // There are a few cases where we need to refer specifically to the availabl e physical width and available physical height.
546 // Relative positioning is one of those cases, since left/top offsets are ph ysical. 545 // Relative positioning is one of those cases, since left/top offsets are ph ysical.
547 LayoutUnit availableWidth() const { return style()->isHorizontalWritingMode( ) ? availableLogicalWidth() : availableLogicalHeight(IncludeMarginBorderPadding) ; } 546 LayoutUnit availableWidth() const { return style()->isHorizontalWritingMode( ) ? availableLogicalWidth() : availableLogicalHeight(IncludeMarginBorderPadding) ; }
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 if (UNLIKELY(inlineBoxWrapper() != nullptr)) 930 if (UNLIKELY(inlineBoxWrapper() != nullptr))
932 deleteLineBoxWrapper(); 931 deleteLineBoxWrapper();
933 } 932 }
934 933
935 ensureRareData().m_inlineBoxWrapper = boxWrapper; 934 ensureRareData().m_inlineBoxWrapper = boxWrapper;
936 } 935 }
937 936
938 } // namespace blink 937 } // namespace blink
939 938
940 #endif // LayoutBox_h 939 #endif // LayoutBox_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/layout/LayoutBox.cpp » ('j') | Source/core/layout/LayoutBox.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698