Chromium Code Reviews

Issue 1081373002: [turbofan] cleanup ParallelMove (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] cleanup ParallelMove - make ParallelMove into a ZoneVector, removing an annoying level of indirection - make MoveOperands hold InstructionOperands instead of pointers, so there's no more operand aliasing for moves - opens up possibility of storing MachineType in allocated operands R=bmeurer@chromium.org BUG= Committed: https://crrev.com/00aec7907936326e9c8f12299419bde12b7eff60 Cr-Commit-Position: refs/heads/master@{#27842}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Stats (+356 lines, -375 lines)
M src/compiler/gap-resolver.h View 1 chunk +1 line, -1 line 0 comments
M src/compiler/gap-resolver.cc View 4 chunks +27 lines, -45 lines 0 comments
M src/compiler/instruction.h View 7 chunks +48 lines, -45 lines 0 comments
M src/compiler/instruction.cc View 10 chunks +19 lines, -25 lines 0 comments
M src/compiler/move-optimizer.cc View 5 chunks +66 lines, -88 lines 0 comments
M src/compiler/register-allocator.h View 4 chunks +14 lines, -8 lines 0 comments
M src/compiler/register-allocator.cc View 23 chunks +84 lines, -77 lines 0 comments
M src/compiler/register-allocator-verifier.cc View 5 chunks +33 lines, -12 lines 0 comments
M src/zone-allocator.h View 1 chunk +2 lines, -0 lines 0 comments
M test/cctest/compiler/test-gap-resolver.cc View 8 chunks +32 lines, -40 lines 0 comments
M test/cctest/compiler/test-instruction.cc View 3 chunks +12 lines, -13 lines 0 comments
M test/cctest/compiler/test-jump-threading.cc View 2 chunks +5 lines, -6 lines 0 comments
M test/unittests/compiler/move-optimizer-unittest.cc View 2 chunks +13 lines, -15 lines 0 comments

Messages

Total messages: 7 (2 generated)
dcarney
ptal
5 years, 8 months ago (2015-04-15 12:29:55 UTC) #2
Benedikt Meurer
lgtm
5 years, 8 months ago (2015-04-15 12:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081373002/140001
5 years, 8 months ago (2015-04-15 12:34:54 UTC) #5
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 8 months ago (2015-04-15 12:36:40 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:36:51 UTC) #7
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/00aec7907936326e9c8f12299419bde12b7eff60
Cr-Commit-Position: refs/heads/master@{#27842}

Powered by Google App Engine