[turbofan] cleanup ParallelMove

test/cctest/compiler/test-instruction.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/compiler/code-generator.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
@@ skipping 65 matching lines @@
     schedule.AddNode(block, node);
     return node;
   }
 
   int NewInstr() {
     InstructionCode opcode = static_cast<InstructionCode>(110);
     TestInstr* instr = TestInstr::New(zone(), opcode);
     return code->AddInstruction(instr);
   }
 
-  UnallocatedOperand* NewUnallocated(int vreg) {
-    return UnallocatedOperand(UnallocatedOperand::ANY, vreg).Copy(zone());
+  UnallocatedOperand Unallocated(int vreg) {
+    return UnallocatedOperand(UnallocatedOperand::ANY, vreg);
   }
 
   RpoNumber RpoFor(BasicBlock* block) {
     return RpoNumber::FromInt(block->rpo_number());
   }
 
   InstructionBlock* BlockAt(BasicBlock* block) {
     return code->InstructionBlockAt(RpoFor(block));
   }
   BasicBlock* GetBasicBlock(int instruction_index) {
@@ skipping 150 matching lines @@
   TestInstr* g = TestInstr::New(R.zone(), 103);
   R.code->StartBlock(R.RpoFor(b0));
   R.code->AddInstruction(i0);
   R.code->AddInstruction(g);
   R.code->EndBlock(R.RpoFor(b0));
 
   CHECK(R.code->instructions().size() == 2);
 
   int index = 0;
   for (auto instr : R.code->instructions()) {
-    UnallocatedOperand* op1 = R.NewUnallocated(index++);
-    UnallocatedOperand* op2 = R.NewUnallocated(index++);
+    UnallocatedOperand op1 = R.Unallocated(index++);
+    UnallocatedOperand op2 = R.Unallocated(index++);
     instr->GetOrCreateParallelMove(TestInstr::START, R.zone())
-        ->AddMove(op1, op2, R.zone());
+        ->AddMove(op1, op2);
     ParallelMove* move = instr->GetParallelMove(TestInstr::START);
     CHECK(move);
-    const ZoneList<MoveOperands>* move_operands = move->move_operands();
-    CHECK_EQ(1, move_operands->length());
-    MoveOperands* cur = &move_operands->at(0);
-    CHECK_EQ(op1, cur->source());
-    CHECK_EQ(op2, cur->destination());
+    CHECK_EQ(1u, move->size());
+    MoveOperands* cur = move->at(0);
+    CHECK(op1 == cur->source());
+    CHECK(op2 == cur->destination());
   }
 }
 
 
 TEST(InstructionOperands) {
   Zone zone;
 
   {
     TestInstr* i = TestInstr::New(&zone, 101);
     CHECK_EQ(0, static_cast<int>(i->OutputCount()));
@@ skipping 23 matching lines @@
   for (size_t i = 0; i < arraysize(outputs); i++) {
     for (size_t j = 0; j < arraysize(inputs); j++) {
       for (size_t k = 0; k < arraysize(temps); k++) {
         TestInstr* m =
             TestInstr::New(&zone, 101, i, outputs, j, inputs, k, temps);
         CHECK(i == m->OutputCount());
         CHECK(j == m->InputCount());
         CHECK(k == m->TempCount());
 
         for (size_t z = 0; z < i; z++) {
-          CHECK(outputs[z].Equals(m->OutputAt(z)));
+          CHECK(outputs[z] == *m->OutputAt(z));
         }
 
         for (size_t z = 0; z < j; z++) {
-          CHECK(inputs[z].Equals(m->InputAt(z)));
+          CHECK(inputs[z] == *m->InputAt(z));
         }
 
         for (size_t z = 0; z < k; z++) {
-          CHECK(temps[z].Equals(m->TempAt(z)));
+          CHECK(temps[z] == *m->TempAt(z));
         }
       }
     }
   }
 }