Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1081033004: Do not inline store if field map was cleared. (Closed)

Created:
5 years, 8 months ago by ulan
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not inline store if field map was cleared. BUG=v8:4023 LOG=NO Committed: https://crrev.com/2f327a5cb4f2ecbb163979fc9b788af765396a62 Cr-Commit-Position: refs/heads/master@{#27779}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Fix comment #

Patch Set 4 : Refactor #

Total comments: 1

Patch Set 5 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -17 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 5 chunks +22 lines, -15 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-4023.js View 1 2 3 4 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ulan
PTAL
5 years, 8 months ago (2015-04-13 09:07:39 UTC) #2
Jakob Kummerow
LGTM with a nit. Thanks for fixing this! https://codereview.chromium.org/1081033004/diff/60001/test/mjsunit/regress/regress-4023.js File test/mjsunit/regress/regress-4023.js (right): https://codereview.chromium.org/1081033004/diff/60001/test/mjsunit/regress/regress-4023.js#newcode1 test/mjsunit/regress/regress-4023.js:1: // ...
5 years, 8 months ago (2015-04-13 09:11:32 UTC) #3
ulan
> LGTM with a nit. Thanks for fixing this! Thank you for investigation and repro! ...
5 years, 8 months ago (2015-04-13 09:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081033004/80001
5 years, 8 months ago (2015-04-13 09:14:56 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-13 09:44:01 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/2f327a5cb4f2ecbb163979fc9b788af765396a62 Cr-Commit-Position: refs/heads/master@{#27779}
5 years, 8 months ago (2015-04-13 09:44:12 UTC) #9
Michael Achenbach
5 years, 8 months ago (2015-04-13 16:20:24 UTC) #10
Message was sent while issue was closed.
On 2015/04/13 09:44:12, I haz the power (commit-bot) wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/2f327a5cb4f2ecbb163979fc9b788af765396a62
> Cr-Commit-Position: refs/heads/master@{#27779}

Please check also these failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...

Powered by Google App Engine
This is Rietveld 408576698