src/objects-debug.cc - Issue 1081033004: Do not inline store if field map was cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 1081033004: Do not inline store if field map was cleared. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix comment Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 69699885d02e899d61f5bec666dff82599022964..3495ad65a6c98f17ffc0c97f42a14b05f82579db 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -290,7 +290,7 @@ void JSObject::JSObjectVerify() {

if (r.IsHeapObject()) DCHECK(value->IsHeapObject());

HeapType* field_type = descriptors->GetFieldType(i);

bool type_is_none = field_type->Is(HeapType::None());

- bool type_is_any = field_type->Is(HeapType::Any());

+ bool type_is_any = HeapType::Any()->Is(field_type);

if (r.IsNone()) {

CHECK(type_is_none);

} else if (!type_is_any && !(type_is_none && r.IsHeapObject())) {

« no previous file with comments | « src/hydrogen.cc ('k') | test/mjsunit/regress/regress-4023.js » ('j') | no next file with comments »