Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1081013002: Revert of Ensuring interception of stream get determined by plugin path before checking mime type. (Closed)

Created:
5 years, 8 months ago by Deepak
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensuring interception of stream get determined by plugin path before checking mime type. (patchset #16 id:300001 of https://codereview.chromium.org/953793003/) Reason for revert: Need to fix some more logic for r475390. Once that will get fixed , I will re land this patch again. Original issue's description: > Ensuring interception of stream get determined by plugin path before checking mime type. > > Earlier we are checking whether a extension with url that have mime type > should be intercepted as stream by checking plugin availablity. > Now we are passing plugin path and then checking whether their is > MimehandlerView Plugin available with that path and then we are allowing > intercepted as stream. So now interception is not depends upon mimetype. > > BUG=443466 > > Committed: https://crrev.com/d7d1167121bfe4b80d2cdf7559171aeff25c02c6 > Cr-Commit-Position: refs/heads/master@{#324187} TBR=jochen@chromium.org,jam@chromium.org,mmenke@chromium.org,raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=443466 Committed: https://crrev.com/e3557dd31bb2b06d6317f04b9274ece25c547d9a Cr-Commit-Position: refs/heads/master@{#324841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -202 lines) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 3 chunks +43 lines, -18 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 4 chunks +45 lines, -64 lines 0 comments Download
M content/browser/loader/buffered_resource_handler_unittest.cc View 12 chunks +6 lines, -94 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 2 chunks +4 lines, -7 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Deepak
Created Revert of Ensuring interception of stream get determined by plugin path before checking mime ...
5 years, 8 months ago (2015-04-13 04:08:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081013002/1
5 years, 8 months ago (2015-04-13 04:08:23 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-13 04:08:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081013002/1
5 years, 8 months ago (2015-04-13 04:10:59 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-13 04:11:01 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-13 13:07:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081013002/1
5 years, 8 months ago (2015-04-13 13:08:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 13:09:17 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 13:10:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3557dd31bb2b06d6317f04b9274ece25c547d9a
Cr-Commit-Position: refs/heads/master@{#324841}

Powered by Google App Engine
This is Rietveld 408576698