Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1080953006: Revert of Introducing the LLVM greedy register allocator. (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introducing the LLVM greedy register allocator. (patchset #10 id:410001 of https://codereview.chromium.org/1061923005/) Reason for revert: Breaks Static Initializers test. http://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/3210/steps/Static-Initializers/logs/stdio Original issue's description: > Introducing the LLVM greedy register allocator. > > This change aims to introduce the separation of the RegisterAllocator model, > using the initial prototype for RegisterAllocatorGreedy as proof of concept. > > Summary: > - new flag, turbo-greedy-regalloc, enabling the new allocator. Default > false. > - separated RegisterAllocator into a base type and two derived, > RegisterAllocatorLinear (the one currently used in TurboFan) and > RegisterAllocatorGreedy (the new one). > - initial, untested impementation for the greedy allocator. > > BUG= > > Committed: https://crrev.com/ec542dea6b6a0cb82d1578a389569d019a59121d > Cr-Commit-Position: refs/heads/master@{#28015} TBR=dcarney@chromium.org,titzer@chromium.org,jarin@chromium.org,jvoung@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1a6f68e7512fc15021bce9b88824f557f6fe3d25 Cr-Commit-Position: refs/heads/master@{#28017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -418 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M src/compiler/register-allocator.h View 5 chunks +5 lines, -46 lines 0 comments Download
M src/compiler/register-allocator.cc View 7 chunks +9 lines, -347 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/zone-containers.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of Introducing the LLVM greedy register allocator.
5 years, 8 months ago (2015-04-22 17:00:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080953006/1
5 years, 8 months ago (2015-04-22 17:00:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 17:01:02 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 17:01:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a6f68e7512fc15021bce9b88824f557f6fe3d25
Cr-Commit-Position: refs/heads/master@{#28017}

Powered by Google App Engine
This is Rietveld 408576698