Remove some more bad ASCII-centric autofill code.

Remove some more bad ASCII-centric autofill code.

Lean on ICU for month names and abbreviations rather than hardcoding
English ones.

BUG=none

Committed: https://crrev.com/20c903e49de077445636a3aadca6a2ab22868cd2
Cr-Commit-Position: refs/heads/master@{#325543}

[Evan Stade, 2015-04-11 01:00:46]

estade@chromium.org changed reviewers:
+ thestig@chromium.org

[Evan Stade, 2015-04-11 01:00:46]

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_field_unittest.cc (right):

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field_unittest.cc:407: "JANV",
"FÉVR.", "MARS", "décembre"
I thought we had to use escape sequences but elsewhere in this file there's some
straight up Kanji so I guess we can use unicode after all.

[Lei Zhang, 2015-04-11 02:44:17]

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:71:
l10n::CaseInsensitiveCompare compare;
Not used?

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:76: if
(base::i18n::StringSearchIgnoringCaseAndAccents(
Create a FixedPatternStringSearchIgnoringCaseAndAccents instance outside of the
for loop?

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:199:
static_cast<size_t>(index) > 12) {
Probably don't need the static_cast anymore.

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_field_unittest.cc (right):

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field_unittest.cc:407: "JANV",
"FÉVR.", "MARS", "décembre"
On 2015/04/11 01:00:46, Evan Stade wrote:
> I thought we had to use escape sequences but elsewhere in this file there's
some
> straight up Kanji so I guess we can use unicode after all.

That's what I did for Quebec.

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:175: static bool
ConvertMonth(const base::string16& month,
The behavior is a bit quirky. Document? Esp. handling of empty |month| and
values like "10".

[Evan Stade, 2015-04-13 18:13:43]

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:71:
l10n::CaseInsensitiveCompare compare;
On 2015/04/11 02:44:17, Lei Zhang wrote:
> Not used?

Done.

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:76: if
(base::i18n::StringSearchIgnoringCaseAndAccents(
On 2015/04/11 02:44:17, Lei Zhang wrote:
> Create a FixedPatternStringSearchIgnoringCaseAndAccents instance outside of
the
> for loop?

Done.

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:199:
static_cast<size_t>(index) > 12) {
On 2015/04/11 02:44:17, Lei Zhang wrote:
> Probably don't need the static_cast anymore.

Done.

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/1080883002/diff/20001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:175: static bool
ConvertMonth(const base::string16& month,
On 2015/04/11 02:44:17, Lei Zhang wrote:
> The behavior is a bit quirky. Document? Esp. handling of empty |month| and
> values like "10".

Done.

[Lei Zhang, 2015-04-13 19:59:13]

https://codereview.chromium.org/1080883002/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/1080883002/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card.cc:716: return true;
I wonder if this should return false. It's not a success IMO.

[Lei Zhang, 2015-04-13 19:59:33]

otherwise lgtm

[Evan Stade, 2015-04-13 21:34:13]

https://codereview.chromium.org/1080883002/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/1080883002/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card.cc:716: return true;
On 2015/04/13 19:59:13, Lei Zhang wrote:
> I wonder if this should return false. It's not a success IMO.

good point. It makes more sense if this check is moved to the callsite.

[Evan Stade, 2015-04-13 23:38:12]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-04-13 23:38:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1080883002/#ps80001
(title: "fiddle with ConvertMonth")

[commit-bot: I haz the power, 2015-04-13 23:38:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1080883002/80001

[commit-bot: I haz the power, 2015-04-14 00:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 00:00:53]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Evan Stade, 2015-04-16 22:10:05]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-04-16 22:10:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1080883002/#ps120001
(title: "fix test")

[commit-bot: I haz the power, 2015-04-16 22:12:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1080883002/120001

[commit-bot: I haz the power, 2015-04-16 23:24:41]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-04-16 23:25:49]

Patchset 7 (id:??) landed as
https://crrev.com/20c903e49de077445636a3aadca6a2ab22868cd2
Cr-Commit-Position: refs/heads/master@{#325543}