Remove some more bad ASCII-centric autofill code.

components/autofill/core/browser/credit_card.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <ostream>
@@ skipping 34 matching lines @@
   }
 
   // Try parsing the |year| as a number.
   if (base::StringToInt(year, num))
     return true;
 
   *num = 0;
   return false;
 }
 
-bool ConvertMonth(const base::string16& month,
-                  const std::string& app_locale,
-                  int* num) {
-  // If the |month| is empty, clear the stored value.
-  if (month.empty()) {
-    *num = 0;
-    return true;
-  }
-
-  // Try parsing the |month| as a number.
-  if (base::StringToInt(month, num))
-    return true;
-
-  // If the locale is unknown, give up.
-  if (app_locale.empty())
-    return false;
-
-  // Otherwise, try parsing the |month| as a named month, e.g. "January" or
-  // "Jan".
-  l10n::CaseInsensitiveCompare compare;
-  UErrorCode status = U_ZERO_ERROR;
-  icu::Locale locale(app_locale.c_str());
-  icu::DateFormatSymbols date_format_symbols(locale, status);
-  DCHECK(status == U_ZERO_ERROR || status == U_USING_FALLBACK_WARNING ||
-         status == U_USING_DEFAULT_WARNING);
-
-  int32_t num_months;
-  const icu::UnicodeString* months = date_format_symbols.getMonths(num_months);
-  for (int32_t i = 0; i < num_months; ++i) {
-    const base::string16 icu_month(months[i].getBuffer(), months[i].length());
-    if (compare.StringsEqual(icu_month, month)) {
-      *num = i + 1;  // Adjust from 0-indexed to 1-indexed.
-      return true;
-    }
-  }
-
-  months = date_format_symbols.getShortMonths(num_months);
-  for (int32_t i = 0; i < num_months; ++i) {
-    const base::string16 icu_month(months[i].getBuffer(), months[i].length());
-    if (compare.StringsEqual(icu_month, month)) {
-      *num = i + 1;  // Adjust from 0-indexed to 1-indexed.
-      return true;
-    }
-  }
-
-  *num = 0;
-  return false;
-}
-
 base::string16 TypeForFill(const std::string& type) {
   if (type == kAmericanExpressCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_AMEX);
   if (type == kDinersCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_DINERS);
   if (type == kDiscoverCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_DISCOVER);
   if (type == kJCBCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_JCB);
   if (type == kMasterCard)
@@ skipping 336 matching lines @@
 void CreditCard::GetMatchingTypes(const base::string16& text,
                                   const std::string& app_locale,
                                   ServerFieldTypeSet* matching_types) const {
   FormGroup::GetMatchingTypes(text, app_locale, matching_types);
 
   base::string16 card_number =
       GetInfo(AutofillType(CREDIT_CARD_NUMBER), app_locale);
   if (!card_number.empty() && StripSeparators(text) == card_number)
     matching_types->insert(CREDIT_CARD_NUMBER);
 
+NOTIMPLEMENTED() << " GETMATCINGTYPES " << text;
   int month;
-  if (ConvertMonth(text, app_locale, &month) && month != 0 &&
+  if (ConvertMonth(text, app_locale, &month) &&
       month == expiration_month_) {
     matching_types->insert(CREDIT_CARD_EXP_MONTH);
   }
 }
 
 const base::string16 CreditCard::Label() const {
   std::pair<base::string16, base::string16> pieces = LabelPieces();
   return pieces.first + pieces.second;
 }
 
@@ skipping 252 matching lines @@
 
 base::string16 CreditCard::Expiration2DigitYearAsString() const {
   if (expiration_year_ == 0)
     return base::string16();
 
   return base::IntToString16(Expiration2DigitYear());
 }
 
 void CreditCard::SetExpirationMonthFromString(const base::string16& text,
                                               const std::string& app_locale) {
-  int month;
-  if (!ConvertMonth(text, app_locale, &month))
+  int month = 0;
+  if (!text.empty() && !ConvertMonth(text, app_locale, &month))
     return;
 
   SetExpirationMonth(month);
 }
 
 void CreditCard::SetExpirationYearFromString(const base::string16& text) {
   int year;
   if (!ConvertYear(text, &year))
     return;
 
   SetExpirationYear(year);
 }
 
 void CreditCard::SetNumber(const base::string16& number) {
   number_ = number;
 
   // Set the type based on the card number, but only for full numbers, not
   // when we have masked cards from the server (last 4 digits).
   if (record_type_ != MASKED_SERVER_CARD)
     type_ = GetCreditCardType(StripSeparators(number_));
 }
 
+// static
+bool CreditCard::ConvertMonth(const base::string16& month,
+                              const std::string& app_locale,
+                              int* num) {
+  if (month.empty())
+    return false;
+
+  // Try parsing the |month| as a number (this doesn't require |app_locale|).
+  if (base::StringToInt(month, num))
+    return true;
+
+  if (app_locale.empty())
+    return false;
+
+  // Otherwise, try parsing the |month| as a named month, e.g. "January" or
+  // "Jan".
+  l10n::CaseInsensitiveCompare compare;
+  UErrorCode status = U_ZERO_ERROR;
+  icu::Locale locale(app_locale.c_str());
+  icu::DateFormatSymbols date_format_symbols(locale, status);
+  DCHECK(status == U_ZERO_ERROR || status == U_USING_FALLBACK_WARNING ||
+         status == U_USING_DEFAULT_WARNING);
+
+  int32_t num_months;
+  const icu::UnicodeString* months = date_format_symbols.getMonths(num_months);
+  for (int32_t i = 0; i < num_months; ++i) {
+    const base::string16 icu_month(months[i].getBuffer(), months[i].length());
+    if (compare.StringsEqual(icu_month, month)) {
+      *num = i + 1;  // Adjust from 0-indexed to 1-indexed.
+      return true;
+    }
+  }
+
+  months = date_format_symbols.getShortMonths(num_months);
+  // Some abbreviations have . at the end (e.g., "janv." in French). We don't
+  // care about matching that.
+  base::string16 trimmed_month;
+  base::TrimString(month, base::ASCIIToUTF16("."), &trimmed_month);
+  for (int32_t i = 0; i < num_months; ++i) {
+    base::string16 icu_month(months[i].getBuffer(), months[i].length());
+    base::TrimString(icu_month, base::ASCIIToUTF16("."), &icu_month);
+    if (compare.StringsEqual(icu_month, trimmed_month)) {
+      *num = i + 1;  // Adjust from 0-indexed to 1-indexed.
+      return true;
+    }
+  }
+
+  return false;
+}
+
 // So we can compare CreditCards with EXPECT_EQ().
 std::ostream& operator<<(std::ostream& os, const CreditCard& credit_card) {
   return os
       << base::UTF16ToUTF8(credit_card.Label())
       << " "
       << credit_card.guid()
       << " "
       << credit_card.origin()
       << " "
       << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_NAME))
@@ skipping 14 matching lines @@
 const char* const kAmericanExpressCard = "americanExpressCC";
 const char* const kDinersCard = "dinersCC";
 const char* const kDiscoverCard = "discoverCC";
 const char* const kGenericCard = "genericCC";
 const char* const kJCBCard = "jcbCC";
 const char* const kMasterCard = "masterCardCC";
 const char* const kUnionPay = "unionPayCC";
 const char* const kVisaCard = "visaCC";
 
 }  // namespace autofill