Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1080673004: Remove network load flags not used in net/ (Closed)

Created:
5 years, 8 months ago by g.mehndiratt
Modified:
5 years, 7 months ago
Reviewers:
kbalazs, Mark P, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove network load flags not used in net/ Removed LOAD_FROM_CACHE_IF_OFFLINE flag and related test cases. BUG=426442 Committed: https://crrev.com/5c8771e8daf16680b63ee4ce8acafcbd23ea325e Cr-Commit-Position: refs/heads/master@{#327015}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove network load flags not used in net #

Total comments: 4

Patch Set 3 : Review comments incorporated. #

Total comments: 2

Patch Set 4 : Patch on latest code because of trybot errors. #

Patch Set 5 : Removed errors due to missing changes. #

Patch Set 6 : Removed errors due to missing changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -184 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/base/load_flags_list.h View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 2 3 4 5 3 chunks +0 lines, -67 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 1 chunk +0 lines, -100 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (14 generated)
g.mehndiratt
Please review the patch.
5 years, 8 months ago (2015-04-23 10:19:59 UTC) #2
mmenke
Thanks for doing this! [+rdsmith]: FYI. https://codereview.chromium.org/1080673004/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/1080673004/diff/1/AUTHORS#newcode579 AUTHORS:579: Gitanshu Mehndiratta <g.mehndiratt@samsung.com> ...
5 years, 8 months ago (2015-04-23 13:16:45 UTC) #3
g.mehndiratt
Review comments incorporated. https://codereview.chromium.org/1080673004/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/1080673004/diff/1/AUTHORS#newcode579 AUTHORS:579: Gitanshu Mehndiratta <g.mehndiratt@samsung.com> On 2015/04/23 13:16:45, ...
5 years, 8 months ago (2015-04-23 14:26:35 UTC) #4
mmenke
Thanks for doing this! Just one more quick comment. You'll also need someone from tools/metrics/OWNERS ...
5 years, 8 months ago (2015-04-23 14:41:28 UTC) #5
Randy Smith (Not in Mondays)
Whoops; sorry about LOAD_FROM_CACHE_IF_OFFLINE. I removed the code that used that a while back, and ...
5 years, 8 months ago (2015-04-23 15:37:17 UTC) #6
g.mehndiratt
Added Mr. mpearson to review.
5 years, 8 months ago (2015-04-24 04:30:29 UTC) #8
g.mehndiratt
On 2015/04/24 04:30:29, g.mehndiratt wrote: Please review histogram.xml
5 years, 8 months ago (2015-04-24 04:32:01 UTC) #9
g.mehndiratt
On 2015/04/23 15:37:17, rdsmith wrote: That's fine i am removing the code where it was ...
5 years, 8 months ago (2015-04-24 04:33:01 UTC) #10
mmenke
https://codereview.chromium.org/1080673004/diff/20001/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/1080673004/diff/20001/net/http/http_cache_transaction.cc#newcode203 net/http/http_cache_transaction.cc:203: }; On 2015/04/23 14:41:28, mmenke (Out 4-27 to 5-1) ...
5 years, 8 months ago (2015-04-24 12:14:01 UTC) #11
g.mehndiratt
Review comments incorporated.Please review. https://codereview.chromium.org/1080673004/diff/20001/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/1080673004/diff/20001/net/http/http_cache_transaction.cc#newcode203 net/http/http_cache_transaction.cc:203: }; On 2015/04/24 12:14:01, mmenke ...
5 years, 8 months ago (2015-04-24 12:58:18 UTC) #12
mmenke
LGTM! Sorry, thought I signed off last time.
5 years, 8 months ago (2015-04-24 17:46:34 UTC) #13
Mark P
histograms.xml lgtm
5 years, 8 months ago (2015-04-24 19:09:14 UTC) #14
kbalazs
https://codereview.chromium.org/1080673004/diff/40001/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (left): https://codereview.chromium.org/1080673004/diff/40001/net/http/http_cache_transaction.cc#oldcode1129 net/http/http_cache_transaction.cc:1129: return SetupEntryForRead(); Are you sure you want to remove ...
5 years, 8 months ago (2015-04-24 20:54:55 UTC) #16
mmenke
https://codereview.chromium.org/1080673004/diff/40001/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (left): https://codereview.chromium.org/1080673004/diff/40001/net/http/http_cache_transaction.cc#oldcode1129 net/http/http_cache_transaction.cc:1129: return SetupEntryForRead(); On 2015/04/24 20:54:55, kbalazs wrote: > Are ...
5 years, 8 months ago (2015-04-24 21:02:52 UTC) #17
kbalazs
On 2015/04/24 21:02:52, mmenke (Out 4-27 to 5-1) wrote: > https://codereview.chromium.org/1080673004/diff/40001/net/http/http_cache_transaction.cc > File net/http/http_cache_transaction.cc (left): ...
5 years, 8 months ago (2015-04-24 21:27:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080673004/40001
5 years, 7 months ago (2015-04-27 04:37:36 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/18747)
5 years, 7 months ago (2015-04-27 04:40:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080673004/60001
5 years, 7 months ago (2015-04-27 06:26:26 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/65729)
5 years, 7 months ago (2015-04-27 06:34:38 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080673004/80001
5 years, 7 months ago (2015-04-27 06:47:24 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/65738)
5 years, 7 months ago (2015-04-27 06:55:21 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080673004/100001
5 years, 7 months ago (2015-04-27 07:02:38 UTC) #35
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-04-27 08:51:47 UTC) #36
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 08:52:51 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5c8771e8daf16680b63ee4ce8acafcbd23ea325e
Cr-Commit-Position: refs/heads/master@{#327015}

Powered by Google App Engine
This is Rietveld 408576698