Remove network load flags not used in net/

net/http/http_cache_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_cache_transaction.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_POSIX)
 #include <unistd.h>
@@ skipping 1105 matching lines @@
   if (!cache_.get())
     return ERR_UNEXPECTED;
 
   // If requested, and we have a readable cache entry, and we have
   // an error indicating that we're offline as opposed to in contact
   // with a bad server, read from cache anyway.
   if (IsOfflineError(result)) {
     if (mode_ == READ_WRITE && entry_ && !partial_) {
       RecordOfflineStatus(effective_load_flags_,
                           OFFLINE_STATUS_DATA_AVAILABLE_OFFLINE);
-      if (effective_load_flags_ & LOAD_FROM_CACHE_IF_OFFLINE) {
-        UpdateTransactionPattern(PATTERN_NOT_COVERED);
-        response_.server_data_unavailable = true;
-        return SetupEntryForRead();
-      }
     } else {
       RecordOfflineStatus(effective_load_flags_,
                           OFFLINE_STATUS_DATA_UNAVAILABLE_OFFLINE);
     }
   } else {
     RecordOfflineStatus(effective_load_flags_,
                         (result == OK ? OFFLINE_STATUS_NETWORK_SUCCEEDED :
                                         OFFLINE_STATUS_NETWORK_FAILED));
   }

[mmenke, 2015/04/23 13:16:45]

This entire block of code is related to the load flag experiment - it should be
removed, too (Include the RecordOfflineStatus method and OFFLINE_STATUS enum).

Since we're removing a histogram, that should be marked obsolete, too (In
tools/metrics/histograms/histograms.xml, locate "HttpCache.OfflineStatus", and
add:
<obsolete>
  Deprecated 4/2015.
</obsolete>

[g.mehndiratt, 2015/04/23 14:26:34]

Acknowledged.

[g.mehndiratt, 2015/04/23 14:26:35]

Other points are accepted. but if i will remove RecordOfflineStatus, this
function is also called in same file with
    RecordOfflineStatus(effective_load_flags_, OFFLINE_STATUS_FRESH_CACHE);
which records another flag. do i need to remove this line also?

i think i got it...because we are removing HttpCache.OfflineStatus flag itself
it makes sense not to record offlineStatus from any where. Please just confirm
for removal of above line.

[mmenke, 2015/04/23 14:41:28]

Correct, that line isn't needed anymore, either.

 
   // If we tried to conditionalize the request and failed, we know
   // we won't be reading from the cache after this point.
   if (couldnt_conditionalize_request_)
     mode_ = WRITE;
 
   if (result == OK) {
     next_state_ = STATE_SUCCESSFUL_SEND_REQUEST;
     return OK;
   }
@@ skipping 1882 matching lines @@
     default:
       NOTREACHED();
   }
 }
 
 void HttpCache::Transaction::OnIOComplete(int result) {
   DoLoop(result);
 }
 
 }  // namespace net