Make arguments to Range methods non-optional

Make arguments to Range methods non-optional

http://dom.spec.whatwg.org/#interface-rage
http://domparsing.spec.whatwg.org/#extensions-to-the-range-interface

Only touch methods defined by the above specs.

The added missing-arguments test passes in Firefox Nightly, IE11
Release Preview and Opera 12.16, so there ought to be fairly little
Web content depending on the old behavior.

BUG=325922
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163463

[jochen (gone - plz use gerrit), 2013-12-09 14:54:10]

lgtm

[arv (Not doing code reviews), 2013-12-09 14:54:12]

LGTM

[commit-bot: I haz the power, 2013-12-09 15:12:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/108063005/40001

[commit-bot: I haz the power, 2013-12-09 15:12:43]

Failed to apply patch for Source/core/dom/Range.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Range.idl
  Hunk #2 FAILED at 47.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/dom/Range.idl.rej

Patch:       Source/core/dom/Range.idl
Index: Source/core/dom/Range.idl
diff --git a/Source/core/dom/Range.idl b/Source/core/dom/Range.idl
index
4b8a5ee574527aff7ec9ec711e085b651964f152..462d972cfddf870543ed21ec477558b682b53a5e
100644
--- a/Source/core/dom/Range.idl
+++ b/Source/core/dom/Range.idl
@@ -31,17 +31,15 @@
     [RaisesException=Getter] readonly attribute boolean collapsed;
     [RaisesException=Getter] readonly attribute Node commonAncestorContainer;
 
-     [RaisesException] void setStart([Default=Undefined] optional Node refNode,
-                                 [Default=Undefined] optional long offset);
-     [RaisesException] void setEnd([Default=Undefined] optional Node refNode,
-                               [Default=Undefined] optional long offset);
-    [RaisesException] void setStartBefore([Default=Undefined] optional Node
refNode);
-    [RaisesException] void setStartAfter([Default=Undefined] optional Node
refNode);
-    [RaisesException] void setEndBefore([Default=Undefined] optional Node
refNode);
-    [RaisesException] void setEndAfter([Default=Undefined] optional Node
refNode);
+    [RaisesException] void setStart(Node refNode, long offset);
+    [RaisesException] void setEnd(Node refNode, long offset);
+    [RaisesException] void setStartBefore(Node refNode);
+    [RaisesException] void setStartAfter(Node refNode);
+    [RaisesException] void setEndBefore(Node refNode);
+    [RaisesException] void setEndAfter(Node refNode);
     [RaisesException] void collapse([Default=Undefined] optional boolean
toStart);
-    [RaisesException] void selectNode([Default=Undefined] optional Node
refNode);
-    [RaisesException] void selectNodeContents([Default=Undefined] optional Node
refNode);
+    [RaisesException] void selectNode(Node refNode);
+    [RaisesException] void selectNodeContents(Node refNode);
 
     // CompareHow
     const unsigned short START_TO_START = 0;
@@ -49,46 +47,41 @@
     const unsigned short END_TO_END     = 2;
     const unsigned short END_TO_START   = 3;
 
-     [RaisesException] short compareBoundaryPoints([Default=Undefined] optional
CompareHow how,
-                                               [Default=Undefined] optional
Range sourceRange);
+    [RaisesException] short compareBoundaryPoints(CompareHow how, Range
sourceRange);
 
     [RaisesException, CustomElementCallbacks] void deleteContents();
     [RaisesException, CustomElementCallbacks] DocumentFragment
extractContents();
     [RaisesException, CustomElementCallbacks] DocumentFragment cloneContents();
-    [RaisesException, CustomElementCallbacks] void
insertNode([Default=Undefined] optional Node newNode);
-    [RaisesException, CustomElementCallbacks] void
surroundContents([Default=Undefined] optional Node newParent);
+    [RaisesException, CustomElementCallbacks] void insertNode(Node newNode);
+    [RaisesException, CustomElementCallbacks] void surroundContents(Node
newParent);
     [RaisesException] Range cloneRange();
     [RaisesException] DOMString toString();
 
     [RaisesException] void detach();
 
+    [RaisesException] boolean isPointInRange(Node refNode, long offset);
+    [RaisesException] short comparePoint(Node refNode, long offset);
+
+    [RaisesException] boolean intersectsNode(Node refNode);
+
     // CSSOM View Module API extensions
 
     ClientRectList getClientRects();
     ClientRect getBoundingClientRect();
 
-    // extensions
+    // DOM Parsing and Serialization
 
-    [RaisesException, CustomElementCallbacks] DocumentFragment
createContextualFragment([Default=Undefined] optional DOMString html);
+    [RaisesException, CustomElementCallbacks] DocumentFragment
createContextualFragment(DOMString html);
 
     // WebKit extensions
 
-    [RaisesException] boolean intersectsNode([Default=Undefined] optional Node
refNode);
-
-    [RaisesException] short compareNode([Default=Undefined] optional Node
refNode);
-
     // CompareResults
     const unsigned short NODE_BEFORE           = 0;
     const unsigned short NODE_AFTER            = 1;
     const unsigned short NODE_BEFORE_AND_AFTER = 2;
     const unsigned short NODE_INSIDE           = 3;
 
-    [RaisesException] short comparePoint([Default=Undefined] optional Node
refNode,
-                       [Default=Undefined] optional long offset);
-
-    [RaisesException] boolean isPointInRange([Default=Undefined] optional Node
refNode,
-                           [Default=Undefined] optional long offset);
+    [RaisesException] short compareNode([Default=Undefined] optional Node
refNode);
 
     [RaisesException] void expand([Default=Undefined] optional DOMString unit);
 };
-

[commit-bot: I haz the power, 2013-12-09 20:29:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/108063005/60001

[commit-bot: I haz the power, 2013-12-09 22:35:18]

Change committed as 163463