Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: Source/core/dom/Range.idl

Issue 108063005: Make arguments to Range methods non-optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Range.idl
diff --git a/Source/core/dom/Range.idl b/Source/core/dom/Range.idl
index 3aa8246a85b0ed7613762d68bf16698ec1175849..d3dd1eb2f0e81c9a7c08c4598388193b81236e3c 100644
--- a/Source/core/dom/Range.idl
+++ b/Source/core/dom/Range.idl
@@ -31,17 +31,15 @@
[RaisesException=Getter] readonly attribute boolean collapsed;
[RaisesException=Getter] readonly attribute Node commonAncestorContainer;
- [RaisesException] void setStart([Default=Undefined] optional Node refNode,
- [Default=Undefined] optional long offset);
- [RaisesException] void setEnd([Default=Undefined] optional Node refNode,
- [Default=Undefined] optional long offset);
- [RaisesException] void setStartBefore([Default=Undefined] optional Node refNode);
- [RaisesException] void setStartAfter([Default=Undefined] optional Node refNode);
- [RaisesException] void setEndBefore([Default=Undefined] optional Node refNode);
- [RaisesException] void setEndAfter([Default=Undefined] optional Node refNode);
+ [RaisesException] void setStart(Node refNode, long offset);
+ [RaisesException] void setEnd(Node refNode, long offset);
+ [RaisesException] void setStartBefore(Node refNode);
+ [RaisesException] void setStartAfter(Node refNode);
+ [RaisesException] void setEndBefore(Node refNode);
+ [RaisesException] void setEndAfter(Node refNode);
[RaisesException] void collapse([Default=Undefined] optional boolean toStart);
- [RaisesException] void selectNode([Default=Undefined] optional Node refNode);
- [RaisesException] void selectNodeContents([Default=Undefined] optional Node refNode);
+ [RaisesException] void selectNode(Node refNode);
+ [RaisesException] void selectNodeContents(Node refNode);
// CompareHow
const unsigned short START_TO_START = 0;
@@ -49,45 +47,41 @@
const unsigned short END_TO_END = 2;
const unsigned short END_TO_START = 3;
- [RaisesException] short compareBoundaryPoints([Default=Undefined] optional CompareHow how,
- [Default=Undefined] optional Range sourceRange);
+ [RaisesException] short compareBoundaryPoints(CompareHow how, Range sourceRange);
[RaisesException, CustomElementCallbacks] void deleteContents();
[RaisesException, CustomElementCallbacks] DocumentFragment extractContents();
[RaisesException, CustomElementCallbacks] DocumentFragment cloneContents();
- [RaisesException, CustomElementCallbacks] void insertNode([Default=Undefined] optional Node newNode);
- [RaisesException, CustomElementCallbacks] void surroundContents([Default=Undefined] optional Node newParent);
+ [RaisesException, CustomElementCallbacks] void insertNode(Node newNode);
+ [RaisesException, CustomElementCallbacks] void surroundContents(Node newParent);
[RaisesException] Range cloneRange();
[RaisesException] DOMString toString();
[RaisesException] void detach();
+ [RaisesException] boolean isPointInRange(Node refNode, long offset);
+ [RaisesException] short comparePoint(Node refNode, long offset);
+
+ [RaisesException] boolean intersectsNode(Node refNode);
+
// CSSOM View Module API extensions
ClientRectList getClientRects();
ClientRect getBoundingClientRect();
- // extensions
+ // DOM Parsing and Serialization
- [RaisesException, CustomElementCallbacks] DocumentFragment createContextualFragment([Default=Undefined] optional DOMString html);
+ [RaisesException, CustomElementCallbacks] DocumentFragment createContextualFragment(DOMString html);
// WebKit extensions
- [RaisesException] boolean intersectsNode([Default=Undefined] optional Node refNode);
-
- [RaisesException] short compareNode([Default=Undefined] optional Node refNode);
-
// CompareResults
const unsigned short NODE_BEFORE = 0;
const unsigned short NODE_AFTER = 1;
const unsigned short NODE_BEFORE_AND_AFTER = 2;
const unsigned short NODE_INSIDE = 3;
- [RaisesException] short comparePoint([Default=Undefined] optional Node refNode,
- [Default=Undefined] optional long offset);
-
- [RaisesException] boolean isPointInRange([Default=Undefined] optional Node refNode,
- [Default=Undefined] optional long offset);
+ [RaisesException] short compareNode([Default=Undefined] optional Node refNode);
[RaisesException] void expand([Default=Undefined] optional DOMString unit);
};
« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698