Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3319)

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.cc

Issue 108063004: Give up focus if the focused view becomes unfocusable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Extracted to common code into FocusManager class Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_view.cc
diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc
index 105b037c06233bc62ffdbfd305c04c2301a3b32b..747aa6eff7a5e456de3f32bf0010b2a1b731a532 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.cc
+++ b/chrome/browser/ui/views/infobars/infobar_view.cc
@@ -89,7 +89,7 @@ views::Link* InfoBarView::CreateLink(const string16& text,
link->SetHorizontalAlignment(gfx::ALIGN_LEFT);
link->set_listener(listener);
link->SetBackgroundColor(background()->get_color());
- link->set_focusable(true);
+ link->SetFocusable(true);
return link;
}
@@ -119,7 +119,7 @@ views::MenuButton* InfoBarView::CreateMenuButton(
menu_button->SetEnabledColor(SK_ColorBLACK);
menu_button->SetHoverColor(SK_ColorBLACK);
menu_button->SetFont(rb.GetFont(ui::ResourceBundle::MediumFont));
- menu_button->set_focusable(true);
+ menu_button->SetFocusable(true);
return menu_button;
}
@@ -175,7 +175,7 @@ views::LabelButton* InfoBarView::CreateLabelButton(
}
}
#endif
- label_button->set_focusable(true);
+ label_button->SetFocusable(true);
return label_button;
}
@@ -259,7 +259,7 @@ void InfoBarView::ViewHierarchyChanged(
rb.GetImageNamed(IDR_CLOSE_1_P).ToImageSkia());
close_button_->SetAccessibleName(
l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE));
- close_button_->set_focusable(true);
+ close_button_->SetFocusable(true);
AddChildView(close_button_);
} else if ((close_button_ != NULL) && (details.parent == this) &&
(details.child != close_button_) && (close_button_->parent() == this) &&

Powered by Google App Engine
This is Rietveld 408576698