Give up focus if the focused view becomes unfocusable

ui/views/focus/focus_manager.cc

Index: ui/views/focus/focus_manager.cc
diff --git a/ui/views/focus/focus_manager.cc b/ui/views/focus/focus_manager.cc
index f52712e62344846226c5aaf819b8f1e7146b63c2..a64c0040c4f6a2cebaded520c06514a743fea0b2 100644
--- a/ui/views/focus/focus_manager.cc
+++ b/ui/views/focus/focus_manager.cc
@@ -353,6 +353,11 @@ void FocusManager::ClearFocus() {
   SetStoredFocusView(focused_view);
 }
 
+void FocusManager::ClearFocusIfUnfocusable() {

[sky, 2013/12/11 21:29:29]

Why is this clearing and not advancing? Also, I think this implementation has to
be more careful. If the Widget the FocusManager is associated with is not active
I believe this will attempt to activate it.

[mohsen, 2013/12/12 18:26:54]

1. About clearing vs advancing, as I stated in my previous message:

"I still clear the focus instead of moving it to another view, as it seems more
natural to me. For example, if the user is typing in a textfield and, for
whatever reason, the textfield gets disabled, I think it is better to clear the
focus instead of moving the focus to another view, because the user may not
notice the change and continue typing and possibly override the other view's
data! But, if you think it is better to move focus to another view, it can be
done easily."

That's my only reason to prefer clearing, and I don't have a strong opinion
about it.

2. In the second sentence of your comment, do you mean that if the widget is not
active, clearing the focus might activate it? If this is the case then we will
have the problem anyway. Or I'm completely missing your point here?

+  if (focused_view_ && !focused_view_->IsAccessibilityFocusable())
+    ClearFocus();
+}
+
 void FocusManager::StoreFocusedView(bool clear_native_focus) {
   View* focused_view = focused_view_;
   // Don't do anything if no focused view. Storing the view (which is NULL), in