chrome/browser/ui/views/frame/browser_view.cc - Issue 108063004: Give up focus if the focused view becomes unfocusable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 108063004: Give up focus if the focused view becomes unfocusable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Extracted to common code into FocusManager class Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 614912143d273fc68672fa3752c4b488d8c4dad5..000f95573e181defa6e544a08f8322ef58c025bb 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1819,7 +1819,7 @@ void BrowserView::Layout() {

views::View::Layout();

// TODO(jamescook): Why was this in the middle of layout code?

- toolbar_->location_bar()->omnibox_view()->set_focusable(IsToolbarVisible());

+ toolbar_->location_bar()->omnibox_view()->SetFocusable(IsToolbarVisible());

// The status bubble position requires that all other layout finish first.

LayoutStatusBubble();