chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc - Issue 108063004: Give up focus if the focused view becomes unfocusable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

Issue 108063004: Give up focus if the focused view becomes unfocusable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Extracted to common code into FocusManager class Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/avatar_menu_bubble_view.cc ('k') | chrome/browser/ui/views/desktop_media_picker_views.cc » ('j') | ui/views/focus/focus_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

index d2e72a3f00d5b73ede0bf38c971083309f77e21e..d13c063236b9d38ddc853b1867a1c6cd06769b22 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

@@ -40,7 +40,7 @@ BookmarkBarInstructionsView::BookmarkBarInstructionsView(

import_link_ = new views::Link(

l10n_util::GetStringUTF16(IDS_BOOKMARK_BAR_IMPORT_LINK));

// We don't want the link to alter tab navigation.

- import_link_->set_focusable(false);

+ import_link_->SetFocusable(false);

import_link_->set_listener(this);

import_link_->set_context_menu_controller(this);

import_link_->SetAutoColorReadabilityEnabled(false);