Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 108063003: Removed internal uses of (almost) deprecated FunctionTemplate::New version. (Closed)

Created:
7 years ago by Sven Panne
Modified:
7 years ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Removed internal uses of (almost) deprecated FunctionTemplate::New version. LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18342

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -511 lines) Patch
M samples/lineprocessor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/shell.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/api.cc View 1 2 3 4 11 chunks +16 lines, -12 lines 0 comments Download
M src/d8.cc View 1 2 2 chunks +16 lines, -16 lines 0 comments Download
M src/d8-posix.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/extensions/externalize-string-extension.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/extensions/free-buffer-extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/gc-extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/trigger-failure-extension.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-accessors.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 146 chunks +450 lines, -325 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 3 4 11 chunks +59 lines, -51 lines 0 comments Download
M test/cctest/test-debug.cc View 1 9 chunks +38 lines, -36 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-decls.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 3 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years ago (2013-12-06 12:04:58 UTC) #1
dcarney
lgtm
7 years ago (2013-12-12 14:40:59 UTC) #2
Sven Panne
7 years ago (2013-12-18 10:32:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r18342 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698