Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: src/extensions/statistics-extension.cc

Issue 108063003: Removed internal uses of (almost) deprecated FunctionTemplate::New version. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/extensions/gc-extension.cc ('k') | src/extensions/trigger-failure-extension.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 20 matching lines...) Expand all
31 namespace internal { 31 namespace internal {
32 32
33 const char* const StatisticsExtension::kSource = 33 const char* const StatisticsExtension::kSource =
34 "native function getV8Statistics();"; 34 "native function getV8Statistics();";
35 35
36 36
37 v8::Handle<v8::FunctionTemplate> StatisticsExtension::GetNativeFunctionTemplate( 37 v8::Handle<v8::FunctionTemplate> StatisticsExtension::GetNativeFunctionTemplate(
38 v8::Isolate* isolate, 38 v8::Isolate* isolate,
39 v8::Handle<v8::String> str) { 39 v8::Handle<v8::String> str) {
40 ASSERT(strcmp(*v8::String::Utf8Value(str), "getV8Statistics") == 0); 40 ASSERT(strcmp(*v8::String::Utf8Value(str), "getV8Statistics") == 0);
41 return v8::FunctionTemplate::New(StatisticsExtension::GetCounters); 41 return v8::FunctionTemplate::New(isolate, StatisticsExtension::GetCounters);
42 } 42 }
43 43
44 44
45 static void AddCounter(v8::Isolate* isolate, 45 static void AddCounter(v8::Isolate* isolate,
46 v8::Local<v8::Object> object, 46 v8::Local<v8::Object> object,
47 StatsCounter* counter, 47 StatsCounter* counter,
48 const char* name) { 48 const char* name) {
49 if (counter->Enabled()) { 49 if (counter->Enabled()) {
50 object->Set(v8::String::NewFromUtf8(isolate, name), 50 object->Set(v8::String::NewFromUtf8(isolate, name),
51 v8::Number::New(*counter->GetInternalPointer())); 51 v8::Number::New(*counter->GetInternalPointer()));
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 args.GetReturnValue().Set(result); 170 args.GetReturnValue().Set(result);
171 } 171 }
172 172
173 173
174 void StatisticsExtension::Register() { 174 void StatisticsExtension::Register() {
175 static StatisticsExtension statistics_extension; 175 static StatisticsExtension statistics_extension;
176 static v8::DeclareExtension declaration(&statistics_extension); 176 static v8::DeclareExtension declaration(&statistics_extension);
177 } 177 }
178 178
179 } } // namespace v8::internal 179 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/extensions/gc-extension.cc ('k') | src/extensions/trigger-failure-extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698