Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart

Issue 1080583003: Emphasize that the XSS tests should not be casually suppressed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review fixes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | tests/html/node_validator_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
diff --git a/tests/html/node_validator_test.dart b/tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
similarity index 98%
rename from tests/html/node_validator_test.dart
rename to tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
index 46b2bebacce7352d0fbbc40121b74ccde8bf6b59..cb0196d7393693b2d0fa3f8ce35dc06b31ca91a2 100644
--- a/tests/html/node_validator_test.dart
+++ b/tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
@@ -2,7 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library validator_test;
+/// This tests HTML validation and sanitization, which is very important
+/// for prevent XSS or other attacks. If you suppress this, or parts of it
+/// please make it a critical bug and bring it to the attention of the
+/// dart:html maintainers.
+library node_validator_test;
import 'dart:html';
import 'dart:svg' as svg;
« no previous file with comments | « tests/html/html.status ('k') | tests/html/node_validator_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698