Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: tests/html/html.status

Issue 1080583003: Emphasize that the XSS tests should not be casually suppressed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review fixes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/html.status
diff --git a/tests/html/html.status b/tests/html/html.status
index 397c550618f54d8a5501ba00122933b56c95524e..8e00a434ae8b801233a93816ac7a184f249280bb 100644
--- a/tests/html/html.status
+++ b/tests/html/html.status
@@ -53,7 +53,9 @@ keyboard_event_test: Fail # Issue 13902
isolates_test: Fail # Issue 13921
indexeddb_3_test: Skip # Issue 19578. Timeouts and RuntimeError
fileapi_test/getFile: Pass, Fail # Issue 20488
-node_validator_test/dom_clobbering: Skip # Dartium is immune to DOM clobbering, so the HTML passes through the sanitizer.
+
+# DO NOT Suppress/Skip the below XSS security test for dart2js - any failure is a P0 bug.
+node_validator_important_if_you_suppress_make_the_bug_critical_test/dom_clobbering: Fail # Dartium is immune to DOM clobbering, so the HTML passes through the sanitizer.
[ $compiler == none && ($runtime == drt || $runtime == dartium || $runtime == ContentShellOnAndroid) && $mode == debug ]
websocket_test/websocket: Skip # Issue 17666
« no previous file with comments | « no previous file | tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698