tests/html/html.status - Issue 1080583003: Emphasize that the XSS tests should not be casually suppressed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/html/html.status

Issue 1080583003: Emphasize that the XSS tests should not be casually suppressed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart » ('j') | tests/html/node_validator_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/html/html.status

diff --git a/tests/html/html.status b/tests/html/html.status

index c9d468dad88af293a4552c49f251fbafa36865a9..2ce65001c1236712cd9ce8bbb93f4c8dd107b693 100644

--- a/tests/html/html.status

+++ b/tests/html/html.status

@@ -54,7 +54,7 @@ keyboard_event_test: Fail # Issue 13902

isolates_test: Fail # Issue 13921

indexeddb_3_test: Skip # Issue 19578. Timeouts and RuntimeError

fileapi_test/getFile: Pass, Fail # Issue 20488

-node_validator_test/dom_clobbering: Skip # Dartium is immune to DOM clobbering, so the HTML passes through the sanitizer.

+node_validator_important_if_you_suppress_make_the_bug_critical_test/dom_clobbering: Skip # Dartium is immune to DOM clobbering, so the HTML passes through the sanitizer.

terry 2015/04/13 17:10:49 Maybe add this comment with blank line before and

Alan Knight 2015/04/13 19:08:36 Done. Also changed it to a Fail rather than Skip,

[ $compiler == none && ($runtime == drt || $runtime == dartium || $runtime == ContentShellOnAndroid) && $mode == debug ]

websocket_test/websocket: Skip # Issue 17666

« no previous file with comments | « no previous file | tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart » ('j') | tests/html/node_validator_test.dart » ('J')