tests/html/html.status - Issue 1080583003: Emphasize that the XSS tests should not be casually suppressed

Side by Side Diff: tests/html/html.status

Issue 1080583003: Emphasize that the XSS tests should not be casually suppressed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart » ('j') | tests/html/node_validator_test.dart » ('J')

OLD	NEW
1 # Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 event_test: Skip # Issue 1996	5 event_test: Skip # Issue 1996

6 interactive_test: Skip # Must be run manually.	6 interactive_test: Skip # Must be run manually.

7 dromaeo_smoke_test: Skip # Issue 14521, 8257	7 dromaeo_smoke_test: Skip # Issue 14521, 8257

8 cross_frame_test: Skip # Test reloads itself. Issue 18558	8 cross_frame_test: Skip # Test reloads itself. Issue 18558

9 svgelement_test/constructors: Skip # Temporary suppression, WIP alanknight	9 svgelement_test/constructors: Skip # Temporary suppression, WIP alanknight

10	10

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 [ $compiler == none && ($runtime == drt \|\| $runtime == dartium \|\| $runtime == Co ntentShellOnAndroid) ]	47 [ $compiler == none && ($runtime == drt \|\| $runtime == dartium \|\| $runtime == Co ntentShellOnAndroid) ]

48 # postMessage in dartium always transfers the typed array buffer, never a view	48 # postMessage in dartium always transfers the typed array buffer, never a view

49 postmessage_structured_test/typed_arrays: Fail	49 postmessage_structured_test/typed_arrays: Fail

50 # Dartium seems to lose the data from the dispatchEvent.	50 # Dartium seems to lose the data from the dispatchEvent.

51 postmessage_structured_test/more_primitives: Fail	51 postmessage_structured_test/more_primitives: Fail

52 async_test: Fail # Uses spawn, not implemented from a DOM isolate in Dartium	52 async_test: Fail # Uses spawn, not implemented from a DOM isolate in Dartium

53 keyboard_event_test: Fail # Issue 13902	53 keyboard_event_test: Fail # Issue 13902

54 isolates_test: Fail # Issue 13921	54 isolates_test: Fail # Issue 13921

55 indexeddb_3_test: Skip # Issue 19578. Timeouts and RuntimeError	55 indexeddb_3_test: Skip # Issue 19578. Timeouts and RuntimeError

56 fileapi_test/getFile: Pass, Fail # Issue 20488	56 fileapi_test/getFile: Pass, Fail # Issue 20488

57 node_validator_test/dom_clobbering: Skip # Dartium is immune to DOM clobbering, so the HTML passes through the sanitizer.	57 node_validator_important_if_you_suppress_make_the_bug_critical_test/dom_clobberi ng: Skip # Dartium is immune to DOM clobbering, so the HTML passes through the s anitizer.
	terry 2015/04/13 17:10:49 Maybe add this comment with blank line before and Maybe add this comment with blank line before and after test so the test is an island all by itself with an important comment: # DO NOT Suppress/Skip the below XSS security test for dart2js - any failure is a P0 bug. node_validator_test/dom_clobbering: Skip # Dartium is immune to DOM clobbering, so the HTML passes through the sanitizer. Alan Knight 2015/04/13 19:08:36 Done. Also changed it to a Fail rather than Skip, Show quoted text On 2015/04/13 17:10:49, terry wrote: > Maybe add this comment with blank line before and after test so the test is an > island all by itself with an important comment: > > # DO NOT Suppress/Skip the below XSS security test for dart2js - any failure is > a P0 bug. > node_validator_test/dom_clobbering: Skip # Dartium is immune to DOM clobbering, > so the HTML passes through the sanitizer. > Done. Also changed it to a Fail rather than Skip, so any future changes in Dartium that left it vulnerable would be noticed.
58	58

59 [ $compiler == none && ($runtime == drt \|\| $runtime == dartium \|\| $runtime == Co ntentShellOnAndroid) && $mode == debug ]	59 [ $compiler == none && ($runtime == drt \|\| $runtime == dartium \|\| $runtime == Co ntentShellOnAndroid) && $mode == debug ]

60 websocket_test/websocket: Skip # Issue 17666	60 websocket_test/websocket: Skip # Issue 17666

61 canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Skip # Issue 1766 6	61 canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Skip # Issue 1766 6

62	62

63 [ $compiler == none && $runtime == ContentShellOnAndroid ]	63 [ $compiler == none && $runtime == ContentShellOnAndroid ]

64 canvasrenderingcontext2d_test/drawImage_video_element: RuntimeError # Issue 1912 7	64 canvasrenderingcontext2d_test/drawImage_video_element: RuntimeError # Issue 1912 7

65 canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Pass, Fail # Issu e 20524	65 canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Pass, Fail # Issu e 20524

66 notification_test/constructors: Skip # Times out on Android Dartium. Issue 22835	66 notification_test/constructors: Skip # Times out on Android Dartium. Issue 22835

67	67

(...skipping 336 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
404 htmlelement_test: StaticWarning	404 htmlelement_test: StaticWarning

405 localstorage_test: StaticWarning	405 localstorage_test: StaticWarning

406 mutationobserver_test: StaticWarning	406 mutationobserver_test: StaticWarning

407 queryall_test: fail	407 queryall_test: fail

408 track_element_constructor_test: StaticWarning	408 track_element_constructor_test: StaticWarning

409 transferables_test: StaticWarning	409 transferables_test: StaticWarning

410 typed_arrays_range_checks_test: StaticWarning	410 typed_arrays_range_checks_test: StaticWarning

411 typing_test: StaticWarning	411 typing_test: StaticWarning

412 webgl_1_test: StaticWarning	412 webgl_1_test: StaticWarning

413 window_nosuchmethod_test: StaticWarning	413 window_nosuchmethod_test: StaticWarning

OLD	NEW