Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1080403004: Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset #3 id:40001 of https://codereview.chromium.org/1094333002/) Reason for revert: Breaks gbemu Original issue's description: > Reland "LayoutDescriptor should inherit from JSTypedArray" > > Original issue's description: > > LayoutDescriptor should inherit from JSTypedArray > > > > It can't just inherit from a FixedTypedArray-like type, as we soon > > assume that a FixedTypedArray-like type is always held by an > > ArrayBufferView-like type > > > > BUG=v8:3996 > > R=ishell@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=ishell@chromium.org,verwaest@chromium.org > LOG=n TBR=ishell@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa Cr-Commit-Position: refs/heads/master@{#27975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -149 lines) Patch
M src/factory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/factory.cc View 4 chunks +3 lines, -88 lines 0 comments Download
M src/layout-descriptor.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/layout-descriptor.cc View 3 chunks +7 lines, -17 lines 0 comments Download
M src/layout-descriptor-inl.h View 4 chunks +3 lines, -26 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Reland "LayoutDescriptor should inherit from JSTypedArray"
5 years, 8 months ago (2015-04-21 15:58:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080403004/1
5 years, 8 months ago (2015-04-21 15:58:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 15:58:26 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:10:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1692380f9374e1afdf506b52006cd3b1b7eb18aa
Cr-Commit-Position: refs/heads/master@{#27975}

Powered by Google App Engine
This is Rietveld 408576698