Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/layout-descriptor.h

Issue 1080403004: Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | src/layout-descriptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/layout-descriptor.h
diff --git a/src/layout-descriptor.h b/src/layout-descriptor.h
index bec442c93597b232fc6fb471996504c3e7864be0..0a14f53198f5c4fd48dd78b28d4b33d5d8792526 100644
--- a/src/layout-descriptor.h
+++ b/src/layout-descriptor.h
@@ -22,7 +22,7 @@
// of the descriptor then the field is also considered tagged.
// Once a layout descriptor is created it is allowed only to append properties
// to it.
-class LayoutDescriptor : public JSTypedArray {
+class LayoutDescriptor : public FixedTypedArray<Uint32ArrayTraits> {
public:
V8_INLINE bool IsTagged(int field_index);
@@ -89,16 +89,11 @@
// Capacity of layout descriptors in bits.
V8_INLINE int capacity();
- V8_INLINE uint32_t get_scalar(int index);
- V8_INLINE void set(int index, uint32_t value);
-
static Handle<LayoutDescriptor> NewForTesting(Isolate* isolate, int length);
LayoutDescriptor* SetTaggedForTesting(int field_index, bool tagged);
private:
static const int kNumberOfBits = 32;
-
- V8_INLINE FixedTypedArray<Uint32ArrayTraits>* GcSafeElements();
V8_INLINE static Handle<LayoutDescriptor> New(Isolate* isolate, int length);
V8_INLINE static LayoutDescriptor* FromSmi(Smi* smi);
« no previous file with comments | « src/factory.cc ('k') | src/layout-descriptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698