Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: content/browser/frame_host/navigator_delegate.h

Issue 1080143003: Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add delegate accessor from Navigator + Re-add scoped trackers Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_delegate.h
diff --git a/content/browser/frame_host/navigator_delegate.h b/content/browser/frame_host/navigator_delegate.h
index 48501f487ff3c5293dc86ef0a4a7c9465d01d517..c9802032eacb6a7c33f25305d12e2dbfc1558446 100644
--- a/content/browser/frame_host/navigator_delegate.h
+++ b/content/browser/frame_host/navigator_delegate.h
@@ -17,6 +17,7 @@ struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
namespace content {
+class FrameTreeNode;
class RenderFrameHostImpl;
struct LoadCommittedDetails;
struct OpenURLParams;
@@ -99,6 +100,20 @@ class CONTENT_EXPORT NavigatorDelegate {
// Returns whether URLs for aborted browser-initiated navigations should be
// preserved in the omnibox. Defaults to false.
virtual bool ShouldPreserveAbortedURLs();
+
+ // A RenderFrame in the specified |frame_tree_node| started loading a new
Charlie Reis 2015/04/15 23:37:53 nit: RenderFrameHost.
Fabrice (no longer in Chrome) 2015/04/16 13:55:25 Done.
+ // document. This correponds to Blink's notion of the throbber starting.
+ // |to_different_document| will be true unless the load is a fragment
+ // navigation, or triggered by history.pushState/replaceState.
+ virtual void DidStartLoading(FrameTreeNode* frame_tree_node,
+ bool to_different_document) {}
+
+ // A document stopped loading. This corresponds to Blink's notion of the
+ // throbber stopping.
+ virtual void DidStopLoading() {}
nasko 2015/04/15 19:17:05 Should this method take FTN as a parameter to be c
Charlie Reis 2015/04/15 23:37:53 I think it's probably ok to omit it until it's nee
Fabrice (no longer in Chrome) 2015/04/16 13:55:25 I think the long term goal is to remove the FrameT
nasko 2015/04/16 16:23:48 Acknowledged.
+
+ // The load progress was changed.
+ virtual void DidChangeLoadProgress() {}
};
} // namspace content

Powered by Google App Engine
This is Rietveld 408576698